| Re: [AD] Bug in Allegro's color convertors? |
[ Thread Index |
Date Index
| More lists.liballeg.org/allegro-developers Archives
]
> Here's a patch to fix this. I have also optimized the MMX 32->24 convertor
> to take 6.5 clocks/4 pixels instead of 10. The non-MMX version grew from
> 10 to 12.5 clocks though.
The patch doesn't compile for me (Mingw32, gcc 2.95.3) because of
+ movl $12(%esi), %edx; /* Read 4[ARGB] */
Moreover, don't append ';' to every line... it's not C!
It looks as though you didn't touch the code inside the
#ifndef ALLEGRO_COLORCONV_ALIGNED_WIDTH
#endif
pairs. Is your new implementation strictly compatible with the old one ? If
no, BeOS folks won't be very impressed.
The results are somewhat psychedelic ;-) both in MMX and non-MMX mode, but
that's not very serious as the convertors neither freeze nor crash. I'll try
to fix them.
--
Eric Botcazou
ebotcazou@xxxxxxxxxx