Re: [AD] Some points about the grabber

[Peter Wang <tjaden@xxxxxxxxxx>]

On 2002-04-12, Eric Botcazou <ebotcazou@xxxxxxxxxx> wrote:
> > > Ok, this turned out to be less tricky and time consuming than I had
> > > thought. I made a modification that checks if the target file, if it
> > > exists, is a symlink. If it is, it asks wether to overwrite the link or
> > > the file it points to.
> > 
> > I'm ok with this feature. What do you think about it, Peter ?
> 
> Hmm... wouldn't it be simpler to always follow the symlinks ?

I think this is the safer approach.  Whether other programs should be
considered broken, I don't know.

If you're going to commit, the patch could possibly use
fix_filename_path instead of realpath.  And there's some minor
formatting and potential buffer overflows.

While you're at it, the fix_filename_path doc should mention that it
expands all sorts of things in Unix.