Re: [AD] gfxtest locks up with 4.0.0 + watcom

[hstokset@xxxxxxxxxx]

Sven Sandberg <svsa1977@xxxxxxxxxx> wrote:

> I've debugged it now, and the problem is in `vbeaf_fetch_mode_list
()' in
> src/misc/vbeaf.c, where it calls GetVideoModeInfo(): `mode_info' is 
NULL
> at this point (it was set to NULL in the beginning of the function 
and
> then never changed). And the driver seems to be supposed to fill
> `mode_info' with contents so it will access a NULL pointer.

Damn, you're right. I wonder why I thought GetVideoModeInfo() 
allocated that
memory in the first place. Attached is an UNTESTED patch which aims 
to fix
several potential memory leaks and fix this particular problem. 
Thanks a
lot!

Sincerely Henrik Stokseth.
----------------------------------------------------------------------
-
E-mail: hstokset@xxxxxxxxxx  Homepage: http://hstokset.n3.net

Attachment: vbeaf_humiliation_fix.diff
Description: Binary data