Re: [AD] unicode.c patch

[ Thread Index | Date Index | More lists.liballeg.org/allegro-developers Archives ]


On Sun, 15 Oct 2000, Benjamin Joel Stover wrote:

> There is a compiling problem with unicode which George just helped me
> fix under GCC v2.96, which is with RedHat 7.0.  You might wanna look it
> over and make sure I didn't do anything bad or break anything heh, I
> just removed the shorts from the defines like GCC and George told me
> to.  :) I guess someone can put it up on CVS?

i think it would be a good idea to start using the new iso c types. see
/usr/include/stdint.h to see what i mean. this way we ensure portability of
code as well. allegro makes too much assumptions about the size of int beeing
32bits. on my old borland compiler the size was 16bit. on ia64 it might be
64bit. instead of making a workaround for a cvs version of gcc wouldn't it be
a good idea to actually fix this properly once and for all?

i propose the following fix:
replace 'short int' with 'int16_t' in src/dos/awdata.c, src/dos/emu8kmid.c and
src/unicode.c

-- 
Sincerely Henrik Stokseth.
-----------------------------------------------------------------------------
Email: hstokset@xxxxxxxxxx Homepage: http://hstokset.n3.net



Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/