| [frogs] Patch for Issue 897 - Key signature should be inherited by all Voices (no matter their accidental style) |
[ Thread Index |
Date Index
| More lilynet.net/frogs Archives
]
- To: frogs@xxxxxxxxxxx
- Subject: [frogs] Patch for Issue 897 - Key signature should be inherited by all Voices (no matter their accidental style)
- From: Owen Tuz <owentuz@xxxxxxxxx>
- Date: Wed, 22 Dec 2010 15:16:38 +0000
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:date:message-id :subject:from:to:content-type; bh=aOouj9wIUnH9aUg/o57xGpImCiI4LSb9Iw6D5Rdz5Ss=; b=t+e6Qs5vDs6vISxv8KLuo9AIeWPdR9Suw7Rj7pdiYHmwSYJfdnVHJSgnZUFWAn2lAL kGWtZSADNl7l56u4p/ah5F6k+3OYF2I6gZ7phliLQXopaD4g7SEGYDy+I3tuvf+yR6ot lqqLH1H8Xr4bVm8MWEivHtkaDRPg+eMTGGeNs=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type; b=Hm26kAlH/98NPdZkDKTiTQXcCthUQ/1BRiQwhfxTnwFPWPh8x6SVePRgCMNBIJhCHf 8+O+ri+oTKuFGWqUOZywJ242flqGpNVrieuhIrNvK0fswzGOPy0DHnl/RFdMPjGWO0Gl gg+WSgAszt39um4NhBI4y/0BGsPel5F9ouhDs=
The issue: http://code.google.com/p/lilypond/issues/detail?id=897&q=label%3Afrog&colspec=ID%20Type%20Status%20Priority%20Stars%20Owner%20Summary
This was a fun one. I spent hours looking through the source learning how scm input works, then moved one line of code and it seems to work :)
I've just moved the accidental_engraver down to the Voice context - best of all, someone had already left a comment in engraver_init.ly suggesting various engravers be moved, so I can't claim much of the credit (I've left the others where they were for now, but based on this I guess it could be worth considering).
If someone could verify that this does indeed fix the issue and not create anything new and horrible, that'd be great. There's ly code to reproduce the issue at the link above.
Thanks,
Owen
Attachment:
0001-Moved-accidental_engraver-to-Voice-context.patch
Description: Binary data