Re: [frogs] Patch for Issue 897 - Key signature should be inherited by all Voices (no matter their accidental style)

[Neil Puttock <n.puttock@xxxxxxxxx>]

On 22 December 2010 15:16, Owen Tuz <owentuz@xxxxxxxxx> wrote:

> If someone could verify that this does indeed fix the issue and not create
> anything new and horrible, that'd be great. There's ly code to reproduce the
> issue at the link above.

Have you run a regresson test check?  That's the quickest way of
checking it doesn't break anything.

I'm not sure whether moving the engraver will affect any accidental
rules adversely, but it *will* have a detrimental effect on accidental
placement: the Accidental_engraver creates one AccidentalPlacement
grob per timestep in a stave, so if you move it to the Voice context,
each voice's accidentals will be oblivious to any other accidentals,
causing collisions.

Here's a simple example showing the problem:

\version "2.13.44"

\relative c' {
  << { cis1 } \\ { ais } >>
}

\layout {
  \context {
    \Staff
    \remove "Accidental_engraver"
  }
  \context {
    \Voice
    \consists "Accidental_engraver"
  }
}

Cheers,
Neil

---
----
Join the Frogs!