[frogs] [PATCH:] Harmonics and ties in tablature

[Marc Hohl <marc@xxxxxxxxxx>]

Hello all,

I just uploaded a patch concerning harmonics and ties to rietveld:

http://codereview.appspot.com/1669041


Just some comments:

I changed the hard-coded values for the harmonic parentheses
to grob properties and added 'whiteout, because the tab note heads can 
be drawn
with or without 'whiteout, so the harmonic brackets should be able to 
adapt this behavior.

Thanks to Neil, I found a solution for tied tab note heads that are 
invisible.
I use the HarmonicParenthesesItem 'after-line-breaking callback, because the
visibility of fret numbers (and therefore for the <>s) depends on the 
final position.

The patch isn't 100% correct yet. If you compile the new regression 
file, the
fret number disappears in the second line. In larger documents, the number
seems to (dis)appear at random - I don't know why this happens.

Thanks in advance for your comments!

PS: for personal clarification: Since I am not a native speaker, I am 
not sure
when I should use "parentheses" or "brackets". These () are parentheses,
and these <> are angled parentheses, isn't it? What's the difference to 
brackets,
or can I use this as a synonym?

Marc




---
----
Join the Frogs!