| Re: [frogs] My First Patch: issue #1063 |
[ Thread Index |
Date Index
| More lilynet.net/frogs Archives
]
- To: Carl Sorensen <c_sorensen@xxxxxxx>
- Subject: Re: [frogs] My First Patch: issue #1063
- From: Rodolfo Zitellini <xhero.gm@xxxxxxxxx>
- Date: Thu, 20 May 2010 13:08:11 +0200
- Cc: "frogs@xxxxxxxxxxx" <frogs@xxxxxxxxxxx>
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=7HwCteUfXJi/zwuYLpDDl+WDYPP0xafpQJMJ37gPUQ4=; b=e5pMShfzKVcG0FXJe0/lf/4ShBcr2aQfxZuUIsQWFol4k5r0I8I/spn6uSmv5NZYgD LMD9IZdGu8GWg9+xNJyLMW5D5SIQr2p5e4Yd3T3hW4iw9MkulCv9O+w3PQokjqfcSnHR hADRLrShZPeeok29gDOKyrvlpgKwjnzQqrrlw=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=F8aRThiZ+oc52Ctam+QcnCO4qsgASUWqrQmx/h0TK1d+rhg/Gy2WYyyHvvS+uZ82J2 MTOYdJfCivdltrRDq+Hai0rs0Ezyb+4wgZinf3aRrXunUbepNKpHjYxjUx7pDLYmTD3T dl/bGFnF5DhUElsjridzj+xJz1DEQYi8R7JN8=
> Wow -- this is the first time I've ever heard "clement" used in a sentence.
> In the U.S., all I hear is "inclement"; I've even heard discussions about
> whether "clement" is a word or not. Thanks for the education!
>
Well I have to admit I am not 100% sure it is correct, but I looked it
up in the dictionary before using it :)
>
> If MyGrob's default value for 'myProp is 1, and I do
>
> \override MyGrob #'myProp = #10
> \override MyGrob #'myProp = #2
> \revert MyGrob #'myProp
>
> the value of 'myProp for MyGrob should be 1, not 10.
>
This works with my patch too. I have noticed, using the debugger, that
every \override generates a call to execute_revert_property() before
calling execute_override_property() on the same property - so you end
up with only two copies (new and old) in the list all the times (this
seems to be done for "normal" and nested properties).
My patch still leaves open the issue on
\override MyGrob #''(nested-prop)
but I beleve this to be unrelated to #1063 (and currently broken, see
last mail :). I did some preliminary work on this, but my mods just
crash the regtests (I mean - literally!) so I think I'm not quite
ready to post a patch :)
Rodolfo
---
----
Join the Frogs!