Re: [frogs] RE: PATCH for getting output-suffix to work (Trackers 714 and 404)

[ Thread Index | Date Index | More lilynet.net/frogs Archives ]


This is a multi-part message in MIME format.
Neil Puttock wrote:
2009/8/20 Ian Hulin <ian@xxxxxxxxxxxx>:
  
Oops, a closing parenthesis got missed out in the source. Here is s
corrected patch, please ignore the previous one - apologies for the noise.
    
LGTM.

Can you fix the indentation and remove the spaces between parentheses?

+    ;;   including accents

this can go on the previous line

+ (set! result (format #f "~a-~a" result output-count)))
+

trailing space

+  parser 'counter-alist (assoc-set! counter-alist output-suffix  (1+
output-count)))

extraneous space after output-suffix

  
Sorted, revised patch attached. 
Carl, is this ready to push or does it need reviewing on rietveld?

Cheers,

Ian







Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/