| Re: [frogs] RE: PATCH for getting output-suffix to work (Trackers 714 and 404) |
[ Thread Index |
Date Index
| More lilynet.net/frogs Archives
]
- To: "frogs@xxxxxxxxxxx" <frogs@xxxxxxxxxxx>
- Subject: Re: [frogs] RE: PATCH for getting output-suffix to work (Trackers 714 and 404)
- From: Carl Sorensen <c_sorensen@xxxxxxx>
- Date: Sat, 29 Aug 2009 11:14:01 -0600
- Accept-language: en-US
- Acceptlanguage: en-US
- Thread-index: AcokDrqb8rb3nVj0QBqQsCAohfRFgAEvV+CK
- Thread-topic: [frogs] RE: PATCH for getting output-suffix to work (Trackers 714 and 404)
On 8/23/09 10:28 AM, "Ian Hulin" <ian@xxxxxxxxxxxx> wrote:
> Neil Puttock wrote:
>>
>> 2009/8/20 Ian Hulin <ian@xxxxxxxxxxxx> <mailto:ian@xxxxxxxxxxxx> :
>>
>>
>>>
>>> Oops, a closing parenthesis got missed out in the source. Here is s
>>> corrected patch, please ignore the previous one - apologies for the noise.
>>>
>>>
>>
>>
>> LGTM.
>>
>> Can you fix the indentation and remove the spaces between parentheses?
>>
>> + ;; including accents
>>
>> this can go on the previous line
>>
>> + (set! result (format #f "~a-~a" result output-count)))
>> +
>>
>> trailing space
>>
>> + parser 'counter-alist (assoc-set! counter-alist output-suffix (1+
>> output-count)))
>>
>> extraneous space after output-suffix
>>
>>
> Sorted, revised patch attached.
> Carl, is this ready to push or does it need reviewing on rietveld?
Thanks for your patience, Ian. This has been a crazy week for me.
The patch is now pushed and the issue has been labeled fixed.
Thanks,
Carl
---
----
Join the Frogs!