[frogs] Re: git problem

["Carl D. Sorensen" <c_sorensen@xxxxxxx>]

Hajo,

Thanks for your patch.  I've applied it with some changes which are
described below.

I've copied this to Frogs so everybody will see it.

The patch you sent had good docstrings, and the format was right, but the
docstrings were in the wrong location.  The docstrings belong after the
argument list and the argument type list for the music function being
defined.

It was a simple fix, and I have made it, so you don't need to do anything
more.

However, I made a mistake when I gave this assignment, because I didn't give
you instructions about how to test your code to make sure it works.  And the
test for these changes requires building the documentation on your machine,
which requires more than a standard executable setup, so not all of the
Frogs may be able to do it.

If you have
1) obtained the lilypond source using git, and
2) configured your machine to be able to build lilypond, at least the
documentation,

you can test your changes by changing to the Documentation/user directory
and running the commands

make web

followed by

make web-clean

You can then see the effects of your changes by looking in
Documentation/user/out-www/lilypond/index.html and following links to
Appendix B.14.

If you don't have this ability, that's fine.  Just send me the patches and
I'll make sure they work.

Thanks,

Carl

On 1/8/09 1:13 PM, "Hajo Dezelski" <dl1sdz@xxxxxxxxxxxxxx> wrote:

> Hello Carl,
> 
> hopefully that I found the right syntax, here is the new patch using rebase,
> so that only one patch is used although two corrections were made.
> 
> Cheers Hajo
> 
> 2009/1/7 Carl D. Sorensen <c_sorensen@xxxxxxx>
>> 
>> 
>> 
>> On 1/6/09 3:27 PM, "Hajo Dezelski" <dl1sdz@xxxxxxxxxxxxxx> wrote:
>> 
>>>> Hello,
>>>> 
>>>> the git problem is solved : git format-patch
>>>> 
>>>> And you will find the patchfile at the end of the letter.
>> 
>> The patch looks wonderful!  I'm glad you've got the process figured out.
>> 
>> One comment:  killCues should be defined as
>> 
>> "Remove cue notes from @code{music}."
>> 
>> rather than
>> 
>> "Removes cue notes from @code{music}."
>> 
>> Could you please make this change?
>> 
>> Then you'll need to commit again, and then you'll need to use git rebase
>> to get only one commit instead of two, so you can put the change into a
>> single patch.
>> 
>> I'm having you do this because knowing how to use git rebase will save you
>> all kinds of time.
>> 
>> Thanks,
>> 
>> Carl
>> 
> 
> 


---

----
Join the Frogs!