| Re: [chrony-dev] [PATCH v1] rtc: handle uninitialized RTC |
[ Thread Index |
Date Index
| More chrony.tuxfamily.org/chrony-dev Archives
]
- To: Miroslav Lichvar <mlichvar@xxxxxxxxxx>
- Subject: Re: [chrony-dev] [PATCH v1] rtc: handle uninitialized RTC
- From: SCHNEIDER Johannes <johannes.schneider@xxxxxxxxxxxxxxxxxxxx>
- Date: Wed, 3 Jul 2024 22:42:03 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=leica-geosystems.com; dmarc=pass action=none header.from=leica-geosystems.com; dkim=pass header.d=leica-geosystems.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RqbAjjdjGGHhn3ThWFzCfU3NYxquoqYkQRMHkWDMPIM=; b=J588BRds1oNw1ueaUu+sPdvKOVX1arVoPdZHV7O/Gqy+U2AQZcvUugOQ6Mwy0OFIgVGNXSzBtmC9d1ad6vdocGsQyTX5nQGpX/JcWS7m5Q82gkzbL5rPbVmdaWf64yBS2phMlAmFaxf3WjMMjdUED2DZv8k6JP5gXSlWCmIuuo1jZTSwSx3Jl0w3FfGyP8/6bqvtJPWwU/Yc3oojsvUfT9inF8xk8GKWcfHxIXu5qcdfAjVuokE1B/VZBYDNVD7veqq2+vlP1c67moLGM4eG5QY2ba5Z9QEKDNncTUWd5r+46lV3xxb197Gei3PASxw4a71idhOn87Qzjx5z9pwvrg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LyRxR9ejjWkNVHjpy6Pwpb//IcAOlhjkyLgpTK39dN20PFIcp5gbOGQKmlMvX5iEHZYET0HwQ+R7r6nlBk3TvlmMVYzdv9HuZdK5Oeu4KEJZNKU6nNzYxMm2JeDbAUDGRzWkpL/zgh7evJ4B6hcusX932/mspK9/BZLMltHM65XH6V62TnyHqwvkNP4Hi9WTflVG3Eg90LaWf2sDXZbN7koH0rcrnLY4e8Dsco3oje+4J1X1f66NoCrIetaDpRceCG7e95ZMSa50vC+6OuuKcuEkuIlhd5nsPCbpT3jrLYvGIh+xTkUHgAX6Oze4FLCVYj7bEnvwrkITjuo9+CzNkA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=leica-geosystems.com;
- Cc: "chrony-dev@xxxxxxxxxxxxxxxxxxxx" <chrony-dev@xxxxxxxxxxxxxxxxxxxx>
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=leica-geosystems.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RqbAjjdjGGHhn3ThWFzCfU3NYxquoqYkQRMHkWDMPIM=; b=LDAKdPn16EV+8DhXjt5Uk8uRD/ps5wCUfKPCgs8F3PnwPg58lf4xqrX2LDzpZo9BvHUUNh0TNe1n9xcbfQ7hJD0iUMXMdjwUGJBF/nXfTg4eVVbAiCKOsdefPe9xWLul7gEdoHHs55F3wppOVyfTatS7OQXAO28zKMKZ+iBKXzs=
- Msip_labels:
- Thread-index: AQHayv7A1O0rw95wkE+SXi578KidCLHhfyCAgAAAhtWAAAWoAIAEF8dc
- Thread-topic: [chrony-dev] [PATCH v1] rtc: handle uninitialized RTC
Hoi Miroslav,
and thanks for the input!
A systemd ExecStartPre in chronyd.service that does this via e.g. core-utils:hwclock is a/the workaround...
The proposed opt-in feature (as it is off by default) could IMO still be a good fit for chrony, when it is used on (embedded) systems as the sole keeper of the RTC.
Thoughts?
gruß
Johannes
________________________________________
From: Miroslav Lichvar <mlichvar@xxxxxxxxxx>
Sent: Monday, July 1, 2024 10:07
To: SCHNEIDER Johannes
Cc: chrony-dev@xxxxxxxxxxxxxxxxxxxx
Subject: Re: [chrony-dev] [PATCH v1] rtc: handle uninitialized RTC
[You don't often get email from mlichvar@xxxxxxxxxx. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
This email is not from Hexagon’s Office 365 instance. Please be careful while clicking links, opening attachments, or replying to this email.
On Mon, Jul 01, 2024 at 07:50:09AM +0000, SCHNEIDER Johannes wrote:
> no there wasn't a kernel side discussion;
> On a system where chrony is running it holds the rtc device/file-handle, e.g. has exclusive access and manages the RTC -> there are no other applications reading/handling the RTC.
> So this patch adds the missing "userspace handling" for this uninitialized RTC corner case.
There are other applications supporting RTCs, which other users might
be using, and they would eventually need to handle this corner
case too, right?
To me it seems it's better to handle this in the place that already
has HW-specific code, the driver. If the RTC maintainers reject that
for some reason, then maybe a simple script running on boot using
hwclock.
--
Miroslav Lichvar
--
To unsubscribe email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "unsubscribe" in the subject.
For help email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "help" in the subject.
Trouble? Email listmaster@xxxxxxxxxxxxxxxxxxxx.