Re: [chrony-dev] [PATCH v1] rtc: handle uninitialized RTC |
[ Thread Index |
Date Index
| More chrony.tuxfamily.org/chrony-dev Archives
]
- To: SCHNEIDER Johannes <johannes.schneider@xxxxxxxxxxxxxxxxxxxx>
- Subject: Re: [chrony-dev] [PATCH v1] rtc: handle uninitialized RTC
- From: Miroslav Lichvar <mlichvar@xxxxxxxxxx>
- Date: Mon, 1 Jul 2024 10:07:00 +0200
- Cc: "chrony-dev@xxxxxxxxxxxxxxxxxxxx" <chrony-dev@xxxxxxxxxxxxxxxxxxxx>
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1719821228; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QDVswA8aRHclQdIv+YOdVXhJcygi0ThhfohgASysZ1o=; b=Nz6blZc7qFyr4ZVapJTN0SPmgoKDD5G56Sel0FON2rOdbM1oVUy0LAFHtckxNGWv5kg3HI arOAfzKJSi2JDNSze1LR3Ma7V+RY6M1JPv81xGMPwdiMKjSqeh/p7dD3WhnZlW/jDwZDEI pPWOxILHTHZEAlwtBkbrKEw+hdgCIcw=
On Mon, Jul 01, 2024 at 07:50:09AM +0000, SCHNEIDER Johannes wrote:
> no there wasn't a kernel side discussion;
> On a system where chrony is running it holds the rtc device/file-handle, e.g. has exclusive access and manages the RTC -> there are no other applications reading/handling the RTC.
> So this patch adds the missing "userspace handling" for this uninitialized RTC corner case.
There are other applications supporting RTCs, which other users might
be using, and they would eventually need to handle this corner
case too, right?
To me it seems it's better to handle this in the place that already
has HW-specific code, the driver. If the RTC maintainers reject that
for some reason, then maybe a simple script running on boot using
hwclock.
--
Miroslav Lichvar
--
To unsubscribe email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "unsubscribe" in the subject.
For help email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "help" in the subject.
Trouble? Email listmaster@xxxxxxxxxxxxxxxxxxxx.