| Re: [chrony-dev] [PATCH v5 5/5] test/unit: add leapdb test |
[ Thread Index |
Date Index
| More chrony.tuxfamily.org/chrony-dev Archives
]
- To: chrony-dev@xxxxxxxxxxxxxxxxxxxx
- Subject: Re: [chrony-dev] [PATCH v5 5/5] test/unit: add leapdb test
- From: Patrick Oppenlander <patrick.oppenlander@xxxxxxxxx>
- Date: Mon, 12 Feb 2024 08:20:46 +1100
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707686457; x=1708291257; darn=chrony.tuxfamily.org; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=T38JZ9e9TeuGzAzRxsNqCzqm+x+P2axi2hA4Jpy/cPg=; b=SpX5f1DWorlJ2N7JOiYqpVXy5PL4WjZVuK9K4b87HxNtntt8CI95O6Il9He6pxhr/B +qiD/iu/1vFbt2jdjzdJB/4BM0Z1okM6xVxgfPRv5QLylpmuDRZJuh6/O5BuQ/+hMnaH oTmGHKs6NMlAAtXwhmLbiIxa2uhr92y4oxxG0C8AQnk+zXOfe+QhrAIqYVzvn4lCXiQs cnpnrOMWKqD3Yq0LfpaE+5innAKZhEh++BQ+NYGnYVXwmVNJ4O+GDr5LPyCFOeTnM5Qe liV60U4KC6o+qfHU6rYyP9guOdjtGAR+xNUb2u3jESHxmV5SfFALbwLO1ZtkHGvZUlXa LkhQ==
On Fri, Feb 9, 2024 at 2:28 AM Miroslav Lichvar <mlichvar@xxxxxxxxxx> wrote:
>
> On Thu, Feb 08, 2024 at 02:36:29PM +1100, patrick.oppenlander@xxxxxxxxx wrote:
> > +} tests[] = {
> > + /* leapdb.list is a cut down version of leap-seconds.list */
> > + {3439756800, 34, LEAP_InsertSecond, 0}, /* 1 Jan 2009 */
> > + {3550089600, 35, LEAP_InsertSecond, 0}, /* 1 Jul 2012 */
> > + {3644697600, 36, LEAP_InsertSecond, 0}, /* 1 Jul 2015 */
> > + {3692217600, 37, LEAP_InsertSecond, 0}, /* 1 Jan 2017 */
> > + {34711891200, 36, LEAP_DeleteSecond, 1}, /* 1 Jan 3000 fake in leapdb.list */
>
> This value is too large to fit in 32-bit time_t. I changed it to 1 Jan
> 2020.
Ah, I didn't think of that as all of the platforms I work with are
64-bit time_t and have been for a few years now.
> There was also an issue I found after I updated the other tests. The
> refclock tai option checked only for leapsectz. And there was a new
> issue reported by static analyzer about uninitialized value, probably
> due to not being able to follow the new function pointers.
Thanks for resolving those remaining issues. Looks like I should have
been running a few more tests beyond "make check". How do you run the
static analyser?
Thanks for getting it merged,
Patrick
> Thanks,
>
> --
> Miroslav Lichvar
>
>
> --
> To unsubscribe email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "unsubscribe" in the subject.
> For help email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "help" in the subject.
> Trouble? Email listmaster@xxxxxxxxxxxxxxxxxxxx.
>
--
To unsubscribe email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "unsubscribe" in the subject.
For help email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "help" in the subject.
Trouble? Email listmaster@xxxxxxxxxxxxxxxxxxxx.