[chrony-dev] [PATCH v5 0/5] support leap-seconds.list

[patrick.oppenlander@xxxxxxxxx]

From: Patrick Oppenlander <patrick.oppenlander@xxxxxxxxx>

Hi Miroslav,

thanks for the feedback. Here's an updated series.

Changes from v4:
* Fix test on systems where mktime() doesn't support leap seconds or where the
  right/UTC timezone is not installed.
* Add a test with a negative leap second.
* Newer leap-second.list doesn't wrap at 80 chars, make the line buffer bigger.
* Fix error path in get_list_leap so that if leap-seconds.list fails to parse
  we don't return new values.

Changes from v3:
* Include cut down leap second database for unit test.
* Add a comment about leap-seconds.list format to chrony.conf.adoc.
* Use UTI_OpenFile() instead of fopen(), fgets() instead of getline().
* Fix handling of blank lines while parsing leap-seconds.list.
* Comment fixes, function & enumerator naming and other minor cleanups.

Changes from v2:
* Fix copyright notices.
* Rework to avoid storing leap-seconds.list in memory, parse on the fly.
* Minimise function pointer use.
* Comment fixes, include ordering, naming and other minor cleanups.

Changes from v1:
* Add a new leapdb module with unit test.
* Make 12 hour caching logic common.
* Make sanity checking logic common.
* Don't cache leap-seconds.list contents between calls.
* Naming and other minor cleanups.

Thanks,



Patrick Oppenlander (5):
  reference: move leap second source into leapdb
  leapdb: make twice per day check logic common
  leapdb: move source check into separate function
  leapdb: support leap-seconds.list as second source
  test/unit: add leapdb test

 Makefile.in           |   2 +-
 conf.c                |  14 +++
 conf.h                |   1 +
 doc/chrony.conf.adoc  |  20 +++-
 leapdb.c              | 270 ++++++++++++++++++++++++++++++++++++++++++
 leapdb.h              |  37 ++++++
 main.c                |   3 +
 reference.c           |  99 +---------------
 test/unit/leapdb.c    | 104 ++++++++++++++++
 test/unit/leapdb.list |  22 ++++
 10 files changed, 475 insertions(+), 97 deletions(-)
 create mode 100644 leapdb.c
 create mode 100644 leapdb.h
 create mode 100644 test/unit/leapdb.c
 create mode 100644 test/unit/leapdb.list

-- 
2.43.0


-- 
To unsubscribe email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "unsubscribe" in the subject.
For help email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "help" in the subject.
Trouble?  Email listmaster@xxxxxxxxxxxxxxxxxxxx.