| Re: [chrony-dev] [PATCH v5 5/5] test/unit: add leapdb test |
[ Thread Index |
Date Index
| More chrony.tuxfamily.org/chrony-dev Archives
]
- To: chrony-dev@xxxxxxxxxxxxxxxxxxxx
- Subject: Re: [chrony-dev] [PATCH v5 5/5] test/unit: add leapdb test
- From: Miroslav Lichvar <mlichvar@xxxxxxxxxx>
- Date: Thu, 8 Feb 2024 16:28:13 +0100
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1707406096; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Kj6JPLeowrWPa2NHMiOe7ItTTORvGWJ/uXgvlqi5Avc=; b=BncJdyrZ/RT5yUygjiWT3np5Lr7OfCftIuRK+yxSRn3SY6nJmf7tLKOp9DTwpxWR2Y12vC xmMw4ycJz+XaHF/2LPhW/a2C3ukFvEsrwC1ypjFEOJ9xS0fqNfCHEap6SkbvME9wv3nsDT Ydy/3Tcxo42Ez7c9CwSCITDlF6CI0+c=
On Thu, Feb 08, 2024 at 02:36:29PM +1100, patrick.oppenlander@xxxxxxxxx wrote:
> +} tests[] = {
> + /* leapdb.list is a cut down version of leap-seconds.list */
> + {3439756800, 34, LEAP_InsertSecond, 0}, /* 1 Jan 2009 */
> + {3550089600, 35, LEAP_InsertSecond, 0}, /* 1 Jul 2012 */
> + {3644697600, 36, LEAP_InsertSecond, 0}, /* 1 Jul 2015 */
> + {3692217600, 37, LEAP_InsertSecond, 0}, /* 1 Jan 2017 */
> + {34711891200, 36, LEAP_DeleteSecond, 1}, /* 1 Jan 3000 fake in leapdb.list */
This value is too large to fit in 32-bit time_t. I changed it to 1 Jan
2020.
There was also an issue I found after I updated the other tests. The
refclock tai option checked only for leapsectz. And there was a new
issue reported by static analyzer about uninitialized value, probably
due to not being able to follow the new function pointers.
Thanks,
--
Miroslav Lichvar
--
To unsubscribe email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "unsubscribe" in the subject.
For help email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "help" in the subject.
Trouble? Email listmaster@xxxxxxxxxxxxxxxxxxxx.