| Re: [chrony-dev] [PATCH] nm-dispatcher: handle NTP servers from DHCP |
[ Thread Index |
Date Index
| More chrony.tuxfamily.org/chrony-dev Archives
]
- To: chrony-dev@xxxxxxxxxxxxxxxxxxxx
- Subject: Re: [chrony-dev] [PATCH] nm-dispatcher: handle NTP servers from DHCP
- From: Miroslav Lichvar <mlichvar@xxxxxxxxxx>
- Date: Mon, 22 Jun 2020 17:18:08 +0200
- Authentication-results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mlichvar@xxxxxxxxxx
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592839143; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=utRrwBLKUPH8NYlVXFTdIFSQNaauxRIw4S7HnxAukEM=; b=KjpOc+E2+iJPx1kraawI2b7Otlbm4J+nUHXXfj52G0HVGG7R6CV3Gr2W9eAF/nbe6qtRIS 4ly2PbmHhxznKqXkL+eIXFisAfAfawpsahq6C9qGSOjCgEhaANKgsgvj+C7d6c2QliJXCV rY5gR2gyt4F1BqZpV++sq8j15+hFUPg=
On Thu, Jun 18, 2020 at 11:21:29AM -0400, Robert Fairley wrote:
> On Thu, Jun 18, 2020 at 6:31 AM Miroslav Lichvar <mlichvar@xxxxxxxxxx> wrote:
> >
> > I think it could be a fragment now, and probably everything else
> > except the default servers. I'll see if I can add an example of
> > a fragmented configuration, which downstreams could use.
> >
I've some questions about fragmented configuration:
- Should they be in /usr/lib/chrony.d or /usr/share/chrony.d?
- Does it make sense to add fragments that only have commented-out
directives? Should they be in /etc/chrony.d? The provided files
shouldn't be edited by the admin, but how will they know about the
important directives?
Do other maintainers have any preferences or suggestions?
> +++ b/examples/chrony.nm-dispatcher.dhcp.in
> @@ -0,0 +1,43 @@
> +chronyc=@CHRONYC@
> +default_server_options=@CHRONY_DEFAULT_SERVER_OPTIONS@
> +server_dir=@CHRONY_SERVER_DIR@
After removing the helper and its directory, I'm now wondering if
those three substitution are worth the trouble. Why not just set them
to "/usr/bin/chronyc", "iburst", and "/var/run/chrony-dhcp"? That
should work for most distributions/users and the remaining can fix
them, like the other provided examples. It could also work with an
example fragment using "sourcedirs" to read the files.
--
Miroslav Lichvar
--
To unsubscribe email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "unsubscribe" in the subject.
For help email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "help" in the subject.
Trouble? Email listmaster@xxxxxxxxxxxxxxxxxxxx.