| Re: [chrony-dev] [PATCH] nm-dispatcher: handle NTP servers from DHCP |
[ Thread Index |
Date Index
| More chrony.tuxfamily.org/chrony-dev Archives
]
- To: chrony-dev@xxxxxxxxxxxxxxxxxxxx
- Subject: Re: [chrony-dev] [PATCH] nm-dispatcher: handle NTP servers from DHCP
- From: Miroslav Lichvar <mlichvar@xxxxxxxxxx>
- Date: Thu, 18 Jun 2020 12:30:32 +0200
- Authentication-results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mlichvar@xxxxxxxxxx
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592476258; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=acqgTi+04N/3rapgqSStWk+4sk6bTGKydIYpha2pIq4=; b=YcizMA6ZX7ctAkuTSOHu6alU40hPn+VdRPTSiwlNvp/WrBQuxyIFRk2k8OAml/Z+sAZ/Sj 1khTpvTjKIub5xW8t59c2hy1bZGdz7129ncHpJZxWCFM5/Lqu+9R637jMVjZ+J42RBh3Dp ZPqxhv436yWNMm2FWB/NwiATPdbye+s=
On Thu, Jun 18, 2020 at 04:01:27AM -0400, Robert Fairley wrote:
> For now I've left https://src.fedoraproject.org/rpms/chrony/pull-request/3
> with a fragment for `sourcedirs`, as the PR is pending the `sourcedirs`
> being packaged. In the meantime I can take a look to see what changes
> are needed in the installer and others. Otherwise, for now having
> `sourcedirs` appended the main `/etc/chrony.conf` would be fine (with
> respect to allowing overriding the propagation from DHCP, we'd
> later on aim to make this its own fragment, if acceptable).
I think it could be a fragment now, and probably everything else
except the default servers. I'll see if I can add an example of
a fragmented configuration, which downstreams could use.
> So far I have tested these patches with the downstream macro
> substitutions and sysconfig patch applied, and using `sourcedirs`
> to specify `/var/run/chrony-dhcp`, in Fedora Rawhide. On modifying the
> `*.sources` files and `chronyc reload sources` (or
> deactivating/activating the NM interface to re-run the dispatcher,
> the sources from a DHCP server appeared in `chronyc sources`.
Great.
The patches look good, except the commit message still mentions the
helper. Can you please update that?
> +++ b/examples/chrony.nm-dispatcher.dhcp.in
> @@ -0,0 +1,44 @@
> +#!/bin/sh
> +# This is a NetworkManager dispatcher script for chronyd to update
> +# its NTP sources passed from DHCP options. Note that this script is
> +# specific to NetworkManager-dispatcher due to use of the
> +# DHCP4_NTP_SERVERS environment variable. For networkd-dispatcher,
> +# an alternative approach is external means such as a dhclient hook.
Maybe don't mention networkd-dispatcher here at all? If someone adds
support to this script, or adds a new script, it will be mentioned
there.
Thanks,
--
Miroslav Lichvar
--
To unsubscribe email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "unsubscribe" in the subject.
For help email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "help" in the subject.
Trouble? Email listmaster@xxxxxxxxxxxxxxxxxxxx.