| Re: [chrony-dev] [PATCH 2/3] refclock: Include TAI offset when adding samples |
[ Thread Index |
Date Index
| More chrony.tuxfamily.org/chrony-dev Archives
]
- To: chrony-dev@xxxxxxxxxxxxxxxxxxxx
- Subject: Re: [chrony-dev] [PATCH 2/3] refclock: Include TAI offset when adding samples
- From: Miroslav Lichvar <mlichvar@xxxxxxxxxx>
- Date: Wed, 11 Oct 2017 11:13:23 +0200
- Authentication-results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=mlichvar@xxxxxxxxxx
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 6880EB673
On Tue, Oct 10, 2017 at 02:39:29PM -0400, Chris Perl wrote:
> On Mon, Oct 9, 2017 at 5:34 AM, Miroslav Lichvar <mlichvar@xxxxxxxxxx> wrote:
> > After the return type there should be a line break.
>
> Re this particular change, I was blindly following the format of
> `REF_IsLeapSecondClose' which was immediately above it, rather than
> looking at the rest of the file (which is in the style you pointed
> out).
>
> I updated it in the v2 I sent, but perhaps `REF_IsLeapSecondClose'
> should be changed too (not in this patch set, but in general).
Yes, it should. I normally fix issues like this only when the line is
modified for another reason to not clutter git history, but if you
submit a patch, I'll take it.
--
Miroslav Lichvar
--
To unsubscribe email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "unsubscribe" in the subject.
For help email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "help" in the subject.
Trouble? Email listmaster@xxxxxxxxxxxxxxxxxxxx.