| Re: [chrony-dev] [PATCH 2/3] refclock: Include TAI offset when adding samples |
[ Thread Index |
Date Index
| More chrony.tuxfamily.org/chrony-dev Archives
]
- To: chrony-dev@xxxxxxxxxxxxxxxxxxxx
- Subject: Re: [chrony-dev] [PATCH 2/3] refclock: Include TAI offset when adding samples
- From: Chris Perl <cperl@xxxxxxxxxxxxxx>
- Date: Tue, 10 Oct 2017 14:39:29 -0400
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=janestreet.com; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=4dLfMwVhAxgd4BRfAAe+vvaWaw9ww0S8ls/MAfa5ysU=; b=ENr1sJoHSkHO9tRJWNNOngRbWWHh4V1ewcgmUv1hwaioYbUHjTutWpgwo5HhGZ/y4J TgulDd+aUP9RWLTvYfWcrAY8gwpzS5Kj857d60/REMupA4DQE8juGd/1AFQQlEfEKrEy oSlXmpRIPcO7szS/RsVb4sM34K8Q1LWa+ifn4=
On Mon, Oct 9, 2017 at 5:34 AM, Miroslav Lichvar <mlichvar@xxxxxxxxxx> wrote:
>> --- a/reference.c
>> +++ b/reference.c
>> @@ -1355,6 +1355,17 @@ int REF_IsLeapSecondClose(void)
>> }
>>
>> /* ================================================== */
>> +int REF_GetTaiOffset(void)
>
> This function should have a "struct timespec *ts" parameter. Reference
> time is independent from the local time and we want to get correct
> offset even if the local time is years behind (e.g. start with no
> RTC).
>
> After the return type there should be a line break.
Re this particular change, I was blindly following the format of
`REF_IsLeapSecondClose' which was immediately above it, rather than
looking at the rest of the file (which is in the style you pointed
out).
I updated it in the v2 I sent, but perhaps `REF_IsLeapSecondClose'
should be changed too (not in this patch set, but in general).
--
To unsubscribe email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "unsubscribe" in the subject.
For help email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "help" in the subject.
Trouble? Email listmaster@xxxxxxxxxxxxxxxxxxxx.