| Re: [chrony-dev] [PATCH 2/3] refclock: Include TAI offset when adding samples |
[ Thread Index |
Date Index
| More chrony.tuxfamily.org/chrony-dev Archives
]
- To: chrony-dev@xxxxxxxxxxxxxxxxxxxx
- Subject: Re: [chrony-dev] [PATCH 2/3] refclock: Include TAI offset when adding samples
- From: Chris Perl <cperl@xxxxxxxxxxxxxx>
- Date: Mon, 9 Oct 2017 08:55:11 -0400
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=janestreet.com; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=OY3ivjgy17tthMXuK83REmzyCwyHGHgQuQrRZO4Wg2M=; b=M4qIby4tauwm6UsdqV/nEEDqMZTs29dlbHqAPmGaWiejQGXAbta74Kary4dtL9tfOn zIomT90hQAdjGWroeqF0ZNOF92IWsogwtHWanit7ed2Jkt56syJkOMC8jYPe8toiTV/S t9MqUAdv2i41aIJTsWcLgdHgfb2RNLyEIGNTM=
On Mon, Oct 9, 2017 at 8:41 AM, Miroslav Lichvar <mlichvar@xxxxxxxxxx> wrote:
> On second thought, it would better to not accumulate samples when the
> TAI offset is unknown, so something like this:
>
> if (instance->tai) {
> tai_offset = REF_GetTaiOffset(sample_time);
> if (!tai_offset) {
> DEBUG_LOG("refclock sample ignored unknown TAI offset");
> return 0;
> }
>
> offset += tai_offset;
> }
Got it. Thanks for the review. I'll send a v2 along soon
incorporating your feedback.
--
To unsubscribe email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "unsubscribe" in the subject.
For help email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "help" in the subject.
Trouble? Email listmaster@xxxxxxxxxxxxxxxxxxxx.