| Re: [chrony-dev] [PATCH] MacOS X - Reset the drift removal timer following a spike in offset_sd |
[ Thread Index |
Date Index
| More chrony.tuxfamily.org/chrony-dev Archives
]
- To: chrony-dev@xxxxxxxxxxxxxxxxxxxx
- Subject: Re: [chrony-dev] [PATCH] MacOS X - Reset the drift removal timer following a spike in offset_sd
- From: Bryan Christianson <bryan@xxxxxxxxxxxxx>
- Date: Sat, 29 Aug 2015 06:32:17 +1200
- Dkim-signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=smtpcorp.com; s=a0-2; h=Feedback-ID:X-Smtpcorp-Track:To:Message-Id:Date: From:Subject; bh=hMqwm3KRxZo9Xp8Je4FB1rIf/kpOhDYx5cl3ASHJ1CQ=; b=ADxwD8D00uJQ c24QO9NMnyRlGyqGdxyMYU1Ihj6rNV6V2fE1JUuFphoedGTb0pM7dfDXPS7vyFwcDIo6wAAx+CSJ1 Z7nJkYYOVLRXt8oKvpJEI9ruJmlkiJ3esbkj8UBpoRsM25ETh4BBpPNOhggJH/2Sl5Kb2h7kQZrC/ DyxQHoOUMT1d5I/K34+xkJJ/i60YDu+/UEHDHwsEhFvB+CuNdR2oYdO4/biSfx00sdE31WhumryEG 25UyESLJhdi0Nc1KdYLYD3HqYwvZAyOE8zle2b0rfTqpFsJmyihQcRBo0m0x8NxQijrcTkowT45oP 6n3F1k91GZMe1yobNoLhKA==;
- Feedback-id: 149811m:149811acx33YQ:149811sj1RR3yXn7:SMTPCORP
> On 29/08/2015, at 12:28 am, Miroslav Lichvar <mlichvar@xxxxxxxxxx> wrote:
>
> On Fri, Aug 28, 2015 at 11:21:01PM +1200, Bryan Christianson wrote:
>> When a large spike occurs in offset_sd the drift removal interval can be
>> set to an excessively long time, although what ever event caused the
>> perturbation has passed. At the next set_sync_status() we now compare
>> the expected drift removal interval with that currently in effect.
>> If they are significantly different, the current timer is cancelled
>> and new cycle started using the new drift removal interval.
>
> Looks good. Just one comment.
>
>> +/* if current_drift_removal_interval / drift_removal_interval exceeds this */
>> +/* ratio, then restart the drift removal timer */
>> +
>> +#define DRIFT_REMOVAL_RESTART_RATIO (DRIFT_REMOVAL_INTERVAL / DRIFT_REMOVAL_INTERVAL_MIN)
>
> I meant to set the ratio directly to 8, so it doesn't change when
> someone adjusts the minimum interval for instance.
>
> I can amend it if that's ok with you.
Please do.
B
--
To unsubscribe email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "unsubscribe" in the subject.
For help email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "help" in the subject.
Trouble? Email listmaster@xxxxxxxxxxxxxxxxxxxx.