| Re: [chrony-dev] [PATCH] MacOS X - Reset the drift removal timer following a spike in offset_sd |
[ Thread Index |
Date Index
| More chrony.tuxfamily.org/chrony-dev Archives
]
On Fri, Aug 28, 2015 at 11:21:01PM +1200, Bryan Christianson wrote:
> When a large spike occurs in offset_sd the drift removal interval can be
> set to an excessively long time, although what ever event caused the
> perturbation has passed. At the next set_sync_status() we now compare
> the expected drift removal interval with that currently in effect.
> If they are significantly different, the current timer is cancelled
> and new cycle started using the new drift removal interval.
Looks good. Just one comment.
> +/* if current_drift_removal_interval / drift_removal_interval exceeds this */
> +/* ratio, then restart the drift removal timer */
> +
> +#define DRIFT_REMOVAL_RESTART_RATIO (DRIFT_REMOVAL_INTERVAL / DRIFT_REMOVAL_INTERVAL_MIN)
I meant to set the ratio directly to 8, so it doesn't change when
someone adjusts the minimum interval for instance.
I can amend it if that's ok with you.
--
Miroslav Lichvar
--
To unsubscribe email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "unsubscribe" in the subject.
For help email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "help" in the subject.
Trouble? Email listmaster@xxxxxxxxxxxxxxxxxxxx.