Re: [chrony-dev] [PATCH] Port to MacOS X

[Bryan Christianson <bryan@xxxxxxxxxxxxx>]

Attachment: 0001-MacOS-X-driver-ported-from-NetBSD.patch
Description: Binary data

Makefile.in:
	1. No longer delete config.* files - will submit separately
	2. remove any .dSYM directories and .DS_Store files

..gitignore:
	added *.dSYM and .DS_Store

I will add the drift removal in a separate patch. The code for the other drivers looks straightforward but I'll need to give it a good test.

*.dSYM directories (they're actually a MacOS X bundle)  are created by configure when both -g is specified, and $CC is compiling an executable from source. The directory for the executable contains the debug info.

Compilation of chronyd and chronyc is actually just a linkage and there must be some other LLVM incantation to force the generation of the debug info into a .dSYM bundle. It is not triggered by default as appears to be the case with docheck.

..DS_Store is a file added to every directory that is viewed via the Finder, the Mac OS file manager. To the best of my knowledge it contains icon/window layout data


> On 12/06/2015, at 1:24 am, Miroslav Lichvar <mlichvar@xxxxxxxxxx> wrote:
> 
> On Thu, Jun 11, 2015 at 05:12:44PM +1200, Bryan Christianson wrote:
>> Think I fixed all the things commented on.
>> I removed the nanosecond calls/conversions so the patch to the driver is now much simpler.
> 
> Thanks, the code looks good to me. I can't verify it works, but I
> assume you did test it :). Will you be interested later in adding a
> drift removal timeout as the other drivers have?
> 
> Just few nits...
> 
>> +++ b/Makefile.in
>> @@ -75,6 +75,9 @@ $(HASH_OBJ) : $(patsubst %.o,%.c,$(HASH_OBJ))
>> distclean : clean
>> 	-rm -f Makefile
>> 	-rm -f chrony.conf.5 chrony.texi chronyc.1 chronyd.8
>> +	-rm -f config.*
> 
> This line doesn't seem to be related to the MacOS X support, can you
> please send it in a separate patch? E.g. subject "makefile: remove
> generated config file in distclean" and add "rm -f config.h config.log".
> 
> 
>> +	-rm -f .DS_Store
> 
>> +	-rm -rf docheck.dSYM
> 
> Is that a file or directory, and why is created only for docheck
> (compiled in the configure script) and not other binaries? Maybe it
> should be rm -f *.dSYM?
> 
> Also, you may want to add them to .gitignore to have clean git status.
> 
> -- 
> Miroslav Lichvar
> 
> -- 
> To unsubscribe email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "unsubscribe" in the subject.
> For help email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "help" in the subject.
> Trouble?  Email listmaster@xxxxxxxxxxxxxxxxxxxx.
>