Re: [chrony-dev] [PATCH] Port to MacOS X

[Miroslav Lichvar <mlichvar@xxxxxxxxxx>]

On Thu, Jun 11, 2015 at 05:12:44PM +1200, Bryan Christianson wrote:
> Think I fixed all the things commented on.
> I removed the nanosecond calls/conversions so the patch to the driver is now much simpler.

Thanks, the code looks good to me. I can't verify it works, but I
assume you did test it :). Will you be interested later in adding a
drift removal timeout as the other drivers have?

Just few nits...

> +++ b/Makefile.in
> @@ -75,6 +75,9 @@ $(HASH_OBJ) : $(patsubst %.o,%.c,$(HASH_OBJ))
>  distclean : clean
>  	-rm -f Makefile
>  	-rm -f chrony.conf.5 chrony.texi chronyc.1 chronyd.8
> +	-rm -f config.*

This line doesn't seem to be related to the MacOS X support, can you
please send it in a separate patch? E.g. subject "makefile: remove
generated config file in distclean" and add "rm -f config.h config.log".


> +	-rm -f .DS_Store

> +	-rm -rf docheck.dSYM

Is that a file or directory, and why is created only for docheck
(compiled in the configure script) and not other binaries? Maybe it
should be rm -f *.dSYM?

Also, you may want to add them to .gitignore to have clean git status.
 
-- 
Miroslav Lichvar

-- 
To unsubscribe email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "unsubscribe" in the subject.
For help email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "help" in the subject.
Trouble?  Email listmaster@xxxxxxxxxxxxxxxxxxxx.