Re: [chrony-dev] 1.24 ready?

[Miroslav Lichvar <mlichvar@xxxxxxxxxx>]

On Fri, Jan 29, 2010 at 08:57:41AM -0800, Bill Unruh wrote:
> One minor bug report-- the chown of the rtc and drift files leaves hundreds of
> messages in syslog

I don't see it here, when running under root or chrony user.

> Jan 24 04:03:13 info chronyd[4328]: Could not change ownsership of drift file
> /var/lib/chrony/chrony.drift.tmp

Is this is with the git version? In reference.c there shouldn't be
"ownsership". (I think this was the typo in the original patch you
sent.)

> (I now have 13000 lines like this in my syslog of the last 5 days.)
> This is with chronyd running as root, and what seems to be happening is that
> the old and new files already have identical ownership and chown is
> objecting to a "change" which is no change at all. I think we need
> to check if the ownership needs changing and to only change it
> if it needs changing. Also, if the system is running as chrony rather than as
> root, to only try changing the group.

Chown should return zero here even when the owner stays the same.

-- 
Miroslav Lichvar

---
To unsubscribe email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "unsubscribe" in the subject.
For help email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "help" in the subject.
Trouble?  Email listmaster@xxxxxxxxxxxxxxxxxxxx.