Re: [vhffs] autotools patch

[Sébastien Le Ray <beuss@xxxxxxxxxxxxx>]

Le Tue, 03 Apr 2007 21:53:31 +0200,
Alexandre Ghisoli <alexandre.ghisoli@xxxxxxx> a écrit :

> Hi there, 
> 

Hello !

> Sorry for the long delay, was very busy and it took me some times to
> convert the install process to autoconf / automake.

No problem, if it's good, no matter how long we have to wait ;)

> 
> It fully support :
> DESTDIR=/tmp/package make install 
> for packages maintainers.
> 
> And for making tarballs to distribute :
> make dist
> 
> will make a .tgz in the working directory that will contain all files
> do distribute.
> 
> Supported configure options are :
> 
>   --with-conf-path=path   Complete path for configuration files
>                           (/etc/vhffs)
>   --with-shell-path=path  Complete path for tux shell (/bin)
>   --with-tools-path=path  Complete path for tools (executables)
>                           (/usr/local/bin)
>   --with-doc-path=path    Complete path for documentation files
>                           (/usr/share/doc/vhffs)
>   --with-api-path=path    Complete path for perl modules (API)
>                           (/usr/share/vhffs/api/Vhffs)
>   --with-web-path=path    Complete path for web interface (panel)
>                           (/usr/share/vhffs/panel)
>   --with-template-path=path
>                           Complete path for web templates (panel)
>                           (/usr/share/vhffs/templates)
>   --with-backend-path=path
>                           Complete path for web backend
>                           (/usr/share/vhffs/backend)
>   --with-robot-path=path  Complete path for robots file
> (/usr/lib/vhffs/bots)
>   --with-jabber-path=path Complete path for jabber pipe
>                           (/usr/share/vhffs/jabber)
>   --with-listengine-path=path
>                           Complete path for jabber pipe
>                           (/usr/lib/vhffs/listengine)
>   --with-listengine-web-path=path
>                           Complete path for listengine web file
>                           (/usr/share/vhffs/listengine)
>   --with-mail-path=path   Complete path for email files
>                           (/usr/share/vhffs/mails)
>   --with-doc-path=path    Complete path for documentation files
>                           (/usr/share/vhffs/mails)
> 
> 
> 
> The attached patch is against trunk version 538.
> 

I quickly looked through the patch and I'll say that it is against
4.1 branche (vhffs-test & Co)...

> Please give me your feedback.

I won't have time to look deeply into it before saturday, maybe someone
(Sylvain ?) can do it before... I'll try to apply it to a just checked
out version.

> 
> Before contributing more, I need some clarifications about license ..
> is it GPL ? Could you explain the future of this project ?

It is BSD licensed (I don't know why the LICENSE file has been
dropped).
What do you mean with "the future" ? For now, we just ended a
huge refactoring on objects creation and fetching. I think there are a
lot of things to do on the panel (remove all redirections to avoid form
blanking, improve design) and on API (Singleton pattern for Vhffs::Main
and possibly Vhffs::Panel::Main)... Tests need to be improved to
From a fonctionnalities point of view, some are here
http://www.vhffs.org/community/doku.php?id=todo but we're open to any
proposition (basically, vhffs evolution follows tuxfamily's evolution)

> 
> Also, is there any coding standard to apply ? (i.e. space,
> indentation, tabs, vars name, position of { and }, ...)

I personnaly use vim with expandtab on and tabstop=4
VHFFS code isn't very coherent from this point of view, we should do
something but code improvment was more important...

> 
> Also a roadmap would be nice ;)

Yes it would be ;)

> 
> Regards

Regards

> 
> --Alexandre

Sébastien

Attachment: signature.asc
Description: PGP signature