Re: [vhffs] autotools patch

[Sébastien Le Ray <beuss@xxxxxxxxxxxxx>]

Le Tue, 03 Apr 2007 21:53:31 +0200,
Alexandre Ghisoli <alexandre.ghisoli@xxxxxxx> a écrit :

> Hi there, 
> 
> Sorry for the long delay, was very busy and it took me some times to
> convert the install process to autoconf / automake.
> 
> It fully support :
> DESTDIR=/tmp/package make install 
> for packages maintainers.
> 
> And for making tarballs to distribute :
> make dist
> 
> will make a .tgz in the working directory that will contain all files
> do distribute.
> 
> Supported configure options are :
> 
>   --with-conf-path=path   Complete path for configuration files
>                           (/etc/vhffs)
>   --with-shell-path=path  Complete path for tux shell (/bin)
>   --with-tools-path=path  Complete path for tools (executables)
>                           (/usr/local/bin)
>   --with-doc-path=path    Complete path for documentation files
>                           (/usr/share/doc/vhffs)
>   --with-api-path=path    Complete path for perl modules (API)
>                           (/usr/share/vhffs/api/Vhffs)
>   --with-web-path=path    Complete path for web interface (panel)
>                           (/usr/share/vhffs/panel)
>   --with-template-path=path
>                           Complete path for web templates (panel)
>                           (/usr/share/vhffs/templates)
>   --with-backend-path=path
>                           Complete path for web backend
>                           (/usr/share/vhffs/backend)
>   --with-robot-path=path  Complete path for robots file
> (/usr/lib/vhffs/bots)
>   --with-jabber-path=path Complete path for jabber pipe
>                           (/usr/share/vhffs/jabber)
>   --with-listengine-path=path
>                           Complete path for jabber pipe
>                           (/usr/lib/vhffs/listengine)
>   --with-listengine-web-path=path
>                           Complete path for listengine web file
>                           (/usr/share/vhffs/listengine)
>   --with-mail-path=path   Complete path for email files
>                           (/usr/share/vhffs/mails)
>   --with-doc-path=path    Complete path for documentation files
>                           (/usr/share/vhffs/mails)
> 
> 
> 
> The attached patch is against trunk version 538.
> 
> Please give me your feedback.
> 
> Before contributing more, I need some clarifications about license ..
> is it GPL ? Could you explain the future of this project ?
> 
> Also, is there any coding standard to apply ? (i.e. space,
> indentation, tabs, vars name, position of { and }, ...)
> 
> Also a roadmap would be nice ;)
> 
> Regards
> 
> --Alexandre


Hi
I started to look at the patch, here are some request/feelings
  - could you add --with-min-uid --with-min-gid switches (they'll set
sequences values for vhffs_users/groups_u/gid_seq in
vhffs-compat/4.0.sql and vhffs-backend/src/pgsql/initdb.sql)
  - do PREFIX and EPREFIX have a real influence ?
  - api-path *must* end with Vhffs, could you enforce this (maybe it's
already done...)
  - configure dies with following error : 
configure: creating ./config.status
config.status: creating vhffs-test-dependencies
config.status: creating vhffs-backend/conf/vhffs.conf
config.status: error: cannot find input file: Makefile.in

Regards
Sebastien

Attachment: signature.asc
Description: PGP signature