Re: [Sawfish] [ANNOUNCE] Sawfish 1.11.91 "The Promised Land"

[Allan Duncan <amd2345@xxxxxxxxxxxxxxx>]

On 31/07/16 05:21, Christopher Roy Bratusek wrote:
> Hi all,
>
> fresh from the oven: Sawfish 1.12 release candidate 1 (1.11.91).

I have been running on the Fedora distros of sawfish for a while, but 
decided to try and build it from source.  I have just run the autogen.sh 
on the suite, and needed to add a few -devel packages (Fedora seperates 
them out from the runtime stuff).

Sawfish itself threw up a curly one about Xtest.  Took some ferreting 
about to work out it was talking about libXtst.

Here's a patch to give a little more meaningful error message:



diff -Naur sawfish_1.11-orig/configure sawfish_1.11/configure
--- sawfish_1.11-orig/configure	2014-11-03 06:09:51.000000000 +1100
+++ sawfish_1.11/configure	2016-07-31 21:06:21.984684175 +1000
@@ -12504,11 +12504,11 @@
 	# Put the nasty error message in config.log where it belongs
 	echo "$XTest_PKG_ERRORS" >&5
 
-	as_fn_error $? "cannot locate Xtest" "$LINENO" 5
+	as_fn_error $? "cannot locate Xtest (libXtst)" "$LINENO" 5
 elif test $pkg_failed = untried; then
      	{ $as_echo "$as_me:${as_lineno-$LINENO}: result: no" >&5
 $as_echo "no" >&6; }
-	as_fn_error $? "cannot locate Xtest" "$LINENO" 5
+	as_fn_error $? "cannot locate Xtest (libXtst)" "$LINENO" 5
 else
 	XTest_CFLAGS=$pkg_cv_XTest_CFLAGS
 	XTest_LIBS=$pkg_cv_XTest_LIBS
diff -Naur sawfish_1.11-orig/configure.in sawfish_1.11/configure.in
--- sawfish_1.11-orig/configure.in	2014-11-03 06:09:25.000000000 +1100
+++ sawfish_1.11/configure.in	2016-07-31 21:07:37.580825623 +1000
@@ -127,8 +127,8 @@
 
 PKG_CHECK_MODULES(XTest, xtst >= 1.0
 		  ,X_EXTRA_LIBS="${X_EXTRA_LIBS} -lXtst"
-		  AC_DEFINE(HAVE_X11_EXTENSIONS_XTST_H, 1, [Have Xtest])
-		  ,AC_MSG_ERROR([cannot locate Xtest]))
+		  AC_DEFINE(HAVE_X11_EXTENSIONS_XTST_H, 1, [Have Xtest (libXtst)])
+		  ,AC_MSG_ERROR([cannot locate Xtest (libXtst)]))
 
 X_SERVER="X.Org X11R7"