Re: [Sawfish] [patch] Two focus bugfixes; enter-exit flickering and x-cycle under focus-*.

[Christopher Roy Bratusek <nano@xxxxxxxxxxx>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

I'm gonna test your patches soon.

I assume qtile is an external window-tiler? if so, did you try out the
one bundled with Sawfish as of 1.10?

Regards,
Chris

On 13.03.2015 08:04, Teika Kazura wrote:
> Hi, Sawfish list. Let me send two patches to fix focus bugs.
> 
> The first one is for the notorious "enter-exit flickers" issue, and
> the second one for that after invocation of commands in x-cycle.jl
> (like cycle-windows and cycle-windows-backwards, and variants like
> -group and -among-group, etc), focus changes by pointer motion get
> ignored in focus-* modes.
> 
> At least both work correctly for me, but my test is far from
> thorough.
> 
> 1. "enter-exit flickers" is fixed by ignoring "pointer-out". It may
> seem necessary, but reacting to "pointer-in" and "enter-root" is
> enough. The fixed symptoms are described in the patch commit log.
> 
> This patch is formed against HEAD, but it seems to work also for
> pre-9bdc8, which was a change to focus.jl in last November. (I
> don't know the exact symptom described in 9bdc8. It seems similar
> to mine, but it tries to fix both enter-exit and enter-only. Mine
> is related only to enter-exit.)
> 
> 2. The fix of x-cycle.jl matters enter-* focus modes, i.e. all but
> "click". It's done by replacing make-timer with a different code.
> Theoretically both should work, but the code with timer doesn't. I
> can't tell why. (Timer seems to be called correctly as far as I
> investigated.) Anyway Librep's timer works in a very esoteric way.
> 
> Let me point out one more thing; the news says that
> `focus-when-mapped' can take the value `maybe', but it isn't there.
> Maybe you can add `default', which is self-exeplanatory. Even in
> that case wm/state/transient.jl can be left intact since the case
> of `default' can be ignored there. (Thus it's equivalent to not
> setting focus-when-mapped.) Thanks for implementing it.
> 
> Am i back? Sorry, no. (If you don't know me...ehem, ask Chris or
> fuchur.) Thanks for developing sawfish.
> 
> Best regards, Teika (Teika kazura)
> 
> # BTW qtile-0.9 now supports python3. I think it's worth trying,
> thus installed it, but not yet tried; it's because now I've
> succeeded in fixing the above two issues.
> 
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJVEE7JAAoJELYMBo/GFnDu0AIP/RVP7vUU82RNiAj2MDAng2U3
tu6kuEsLr1tKYlesIYb+4dLslGngZJJkMgnaT2kDWUTb5Sx4J0AYSrNVdAgYrsev
0/QKXt3J9aN6Y0PLAknlWdbBAbsWO02iHg9qjHqeNOLW2KrAeIXR2pKEqRCEDM97
lkEYWBLBn87gLOiI0Og1k0sn+k7JmrvGOWX1+ZYgEOBTkx8wjY0uEcJnUzlh/oM4
pgFQfNfxfojHUxCVnY6CdPHqgC9E+kgIgY94oq2W5SQ8Zd5j91JNm3iEgd/vyahc
HrDwb8kgejwAIuAobS2MduSx+L+/kuOWm5L2WkLLpLvqTFN7mrnOkdc566yk+v4p
QRkOWpR0Zrdu8tzPcNYKzMMwSR/TbdzC5oyUatK2iG4FbOvgRx+EHiVDfaEEGrtF
eAcsRnmiXLrvjCM3YyJ0Izo5DN3kZD3RAe6G5BkRgOOG9VoOd56r3yt0fK45AdHs
c77gGZ7bhn2wGupgy0xooXbnO50yFRxu1wN86u+QmE5IKdD8hnee5XLN9cydKEpt
YTI6K4z8qg0u0qLTpjdIaIFrdyxb8LNJ3saWk7tFnP929F3Cu6feI6cEwx6T+aT2
lmIvmMcyMT0QM60DsRF72QEDeb6U/aF6VOghyQmrk/8DeipV0sU25/HXi9OBQjnA
OAJqCE+WU/pmNTQZ9XPi
=ZZoJ
-----END PGP SIGNATURE-----

-- 
Sawfish ML