Re: [Sawfish] Lowered window retaining focus (version 1.5.3)

[fuchur <flohtransporter@xxxxxxxxx>]

Hi,

On Mon, 1 Sep 2014 18:41:30 +0200
wrote "Robert 'Bobby' Zenz" <Robert.Zenz@xxxxxxxxxxxxxx>:

>I can confirm that this is the case with Sawfish 1.9.99 (compiled
>from git head), focus mode set to "enter-only". Though the limiting
>factor is the click, everything works as expected as long as I'm only
>using keyboard commands.
>
>So I'd say that this is a bug in Sawfish somewhere, some quirk with
>handling the click event. I can very well imagine that there is a
>problem with said click event and the order in which further events
>appear (or not appear).
>
>Yes, there are packages for Debian, see the mails from Chris a few days
>ago.
>
>> Where to get?
>> =============
>> 
>> Tarballs: http://download.tuxfamily.org/librep/
>> Debian*: http://apt.nanolx.org/pool/main/libr/librep
>> 
>> * available for amd64/i386/armhf. Build in progress.
>
>
>On Mon, 01 Sep 2014 10:31:16 +0100
>Malcolm Bennett <m.bennett@xxxxxxx> wrote:
>
>> Hello,
>> 
>>   Having just updated my Debian box to the current stable version 
>> (Wheezy 7.6 which uses Sawfish 1.5.3), I am having difficulty in 
>> recustomising sawfish to correspond to my habits.
>> 
>>   My required 'user-behaviour' is that the window under the cursor 
>> should have the focus at all times (focus stealing).
>> 
>>   The problem that I am having occurs on pushing the currently
>> focussed window to the bottom of the stack (with lower-window). The
>> window which then appears under the cursor no longer has the focus
>> (as it did in Debian Squeeze 6.0.5 which used Sawfish 1.3.5.2).
>> 
>>   My lisp being excessively rusty (last 'used' about thirty years
>> ago), I would
>> appreciate it if someone could mail the function to use (I push down
>> with Alt-Shift-Click1).
>> 
>>   I am sure the reply will be to update to the latest version, but 
>> having had one shot at it, I would much prefer not having to go
>> through that attempt again.
>>   Has the current version of Sawfish been ported to the current
>> stable version of Debian ? (ie does a .deb exist which does not
>> require dependencies outside the stable package framework).
>> 
>> Thanks,
>> Malcolm
>> 
>> NB: The menu entry:
>>    Customize->Focus->"Give focus to windows even when they haven't
>> asked for it"
>> seems to have no effect when checked (it becomes unchecked after
>> closing).
>> 
>> 
>
>

I can reproduces this. I have build a patch, but this patch must check
by the author from the comment/changes in focus.jl (this patch remove
some changes from the author).

The kde problems can fix with window-rules. 

-- 
Regards,
Fuchur

GPG Fingerprint: CA3B 8204 5B3E 6D48 6D53  C116 E5BC 70D5 B8D7 B2B0

Attachment: Bildschirmfoto - 01.09.2014 - 21:45:10.png
Description: PNG image

Attachment: Bildschirmfoto - 01.09.2014 - 21:45:55.png
Description: PNG image

--- /usr/share/sawfish/lisp/sawfish/wm/focus.jl.orgi
+++ /usr/share/sawfish/lisp/sawfish/wm/focus.jl
@@ -144,34 +144,11 @@
 
 ;;; modes
 
-  #|
-  From sawfish-1.5.0, enter-notify events invoked by grab are
-  ignored in enter-exit and enter-only. This has a down side, too,
-  but first let us see what's the intention.
-
-  The problem that this solves is when you press Alt F2 in KDE, the
-  Run Command popup appears and gets focused (if focus-when-mapped is
-  non-nil), you start typing, the completion list pops up and takes
-  focus, then you type a bit further and the completion list
-  disappears.  Focus used to revert to the window the pointer was in,
-  which usually was not the Run Command popup.  transient-unmap-window
-  tries hard to get it right, then the grab-induced enter-notify
-  brought focus to the wrong window anyway.
-
-  The problem that this causes is when you open the KDE main menu by
-  clicking the K icon in the panel, move the mouse into some
-  application window and click to dismiss the open menu, focus reverts
-  to the panel. You have to move the pointer out of the application
-  window and back in to get it focused.
-  |#
   (define-focus-mode 'enter-exit
     (lambda (w action . args)
       (case action
 	((pointer-in)
-	 (when (and (window-really-wants-input-p w)
-		    ;; ignore grab/ungrab enter events
-		    ;; See the above long comment
-		    (eq (car args) 'normal))
+	 (when (window-really-wants-input-p w)
 	   (set-input-focus w)))
 	((pointer-out)
 	 ;; ignore grab/ungrab leave events
@@ -190,13 +167,10 @@
            (set-input-focus w))))))
 
   (define-focus-mode 'enter-only
-    (lambda (w action . args)
+    (lambda (w action)
       (case action
 	((pointer-in)
-	 (when (and (window-really-wants-input-p w)
-		    ;; ignore grab/ungrab enter events
-		    ;; See the comment above enter-exit
-		    (eq (car args) 'normal))
+	 (when (window-really-wants-input-p w)
 	   (set-input-focus w)))
 	((warp-if-necessary)
 	 (let ((current (query-pointer-window)))

Attachment: signature.asc
Description: PGP signature