Re: [Sawfish] Avoid Focus for KDE Notification Windows?

[fuchur <flohtransporter@xxxxxxxxx>]

Hi,

On Sun, 1 Sep 2013 05:41:15 +0200
wrote fuchur <flohtransporter@xxxxxxxxx>:

>Hi,
>
>On Sun, 1 Sep 2013 05:17:54 +0200
>wrote fuchur <flohtransporter@xxxxxxxxx>:
>
>>Hi,
>>
>>On Wed, 13 Mar 2013 10:47:00 +0900
>>wrote "Andrew A. Adams" <aaa@xxxxxxxxxxx>:
>>
>>>
>>>Thank you Fuchur, That seems to have solved it, without introducing any other 
>>>problems that I can see.
>>>
>>
>>I am a new KDE user now (gnome killing me). I have the same problems
>>with plasma. Settings never-focus by window rules is not a good idea,
>>then you can't for example use the search box from k-menu. Here are my
>>settings as attachment and you also need the patch by this mail. It
>>should also not "kill" other things in sawfish but need more testing.
>>Comments welcome.
>>
>
>I have it also testet now with all other focus modes and with the patch
>and the window rule i have no problems here. 
>

Here is a update for the patch. Remove the previous patch and apply
this one. This patch work with all focus modes/settings and you can
choose whether a window got focus-when-mapped always or never.

-- 
Regards,
Fuchur

GPG Fingerprint: CA3B 8204 5B3E 6D48 6D53  C116 E5BC 70D5 B8D7 B2B0

diff -urNad sawfish.orig/lisp/sawfish/wm/ext/match-window.jl sawfish/lisp/sawfish/wm/ext/match-window.jl
--- sawfish.orig/lisp/sawfish/wm/ext/match-window.jl	2013-09-01 09:08:35.000000000 +0200
+++ sawfish/lisp/sawfish/wm/ext/match-window.jl	2013-09-01 09:11:07.000000000 +0200
@@ -84,7 +84,7 @@
 	       )
      (focus ,(_ "Focus")
             (raise-on-focus boolean)
-            (focus-when-mapped boolean)
+            (focus-when-mapped (choice always never))
             (never-focus boolean)
             (focus-click-through boolean)
             (focus-mode ,(lambda () `(choice ,@focus-modes)))
diff -urNad sawfish.orig/lisp/sawfish/wm/state/transient.jl sawfish/lisp/sawfish/wm/state/transient.jl
--- sawfish.orig/lisp/sawfish/wm/state/transient.jl	2013-09-01 09:08:35.000000000 +0200
+++ sawfish/lisp/sawfish/wm/state/transient.jl	2013-09-01 09:26:21.000000000 +0200
@@ -180,9 +180,10 @@
                                 (and x-for (window-get x-for 'desktop))))
                           (or (and
                                focus-windows-when-mapped
+                               (not (eq (window-get w 'focus-when-mapped) 'never))
                                (not (window-get w 'never-focus))
                                (not (window-get w 'inhibit-focus-when-mapped)))
-                              (window-get w 'focus-when-mapped))))))
+                              (eq (window-get w 'focus-when-mapped) 'always))))))
       (unless (window-get w 'sticky)
         (when (not (eq (car (window-in-workspace-p w current-workspace))
                        (car (window-workspaces w))))

Attachment: signature.asc
Description: PGP signature