[Sawfish] Very nice bug in frames.jl

[fuchur <flohtransporter@xxxxxxxxx>]

Hi,

I use custom cursors in sawfish. Sometimes sawfish crash with:

Lisp backtrace:
#7   rebuild-frame (#<window 9200003>)
#6   update-button-cursor-shape ...
#5   call-with-exception-handler ...
#4   custom-set-symbol ...
#3   nokogiri-apply-changes (((next-workspace-button-cursor-shape .
ll_angel))) #2   eval ...
#1   user-eval ...
#0   server-eval ...

frame error: (error "no such cursor" ())

After more as a hour and reading again and again frames.jl and
cursorfont.h i now know the difference between ll_angel and
ll_angle.

The patch fix also the cursors sb_bottom_arrow and sb_top_arrow (not in
my cursorfont.h by debian and gentoo an it can also crash sawfish)

And i add "range" by custom border width (spinbutton goes crazy, no
stop)

-- 
Regards,
Fuchur

GPG Fingerprint: CA3B 8204 5B3E 6D48 6D53  C116 E5BC 70D5 B8D7 B2B0

--- sawfish/lisp/sawfish/wm/frames.jl.orgi
+++ sawfish/lisp/sawfish/wm/frames.jl
@@ -440,9 +440,9 @@
     "Cursor shape for menu button: \\left"
     :type (choice arrow box_spiral center_ptr circle cross cross_reverse
                   crosshair diamond_cross dotbox double_arrow draped_box
-		  fleur hand1 hand2 iron_cross left_ptr ll_angel mouse
+		  fleur hand1 hand2 iron_cross left_ptr ll_angle mouse
 		  pencil pirate plus question_arrow right_ptr sb_left_arrow
-		  sb_right_arrow sb_bottom_arrow sb_top_arrow spider star
+		  sb_right_arrow sb_down_arrow sb_up_arrow spider star
 		  target tcross xterm X_cursor)
     :depends use-custom-button-cursor-shape
     :group appearance
@@ -452,9 +452,9 @@
     "Cursor shape for close button: \\left"
     :type (choice arrow box_spiral center_ptr circle cross cross_reverse
                   crosshair diamond_cross dotbox double_arrow draped_box
-		  fleur hand1 hand2 iron_cross left_ptr ll_angel mouse
+		  fleur hand1 hand2 iron_cross left_ptr ll_angle mouse
 		  pencil pirate plus question_arrow right_ptr sb_left_arrow
-		  sb_right_arrow sb_bottom_arrow sb_top_arrow spider star
+		  sb_right_arrow sb_down_arrow sb_up_arrow spider star
 		  target tcross xterm X_cursor)
     :depends use-custom-button-cursor-shape
     :group appearance
@@ -464,9 +464,9 @@
     "Cursor shape for iconify button: \\left"
     :type (choice arrow box_spiral center_ptr circle cross cross_reverse
                   crosshair diamond_cross dotbox double_arrow draped_box
-		  fleur hand1 hand2 iron_cross left_ptr ll_angel mouse
+		  fleur hand1 hand2 iron_cross left_ptr ll_angle mouse
 		  pencil pirate plus question_arrow right_ptr sb_left_arrow
-		  sb_right_arrow sb_bottom_arrow sb_top_arrow spider star
+		  sb_right_arrow sb_down_arrow sb_up_arrow spider star
 		  target tcross xterm X_cursor)
     :depends use-custom-button-cursor-shape
     :group appearance
@@ -476,9 +476,9 @@
     "Cursor shape for maximize button: \\left"
     :type (choice arrow box_spiral center_ptr circle cross cross_reverse
                   crosshair diamond_cross dotbox double_arrow draped_box
-		  fleur hand1 hand2 iron_cross left_ptr ll_angel mouse
+		  fleur hand1 hand2 iron_cross left_ptr ll_angle mouse
 		  pencil pirate plus question_arrow right_ptr sb_left_arrow
-		  sb_right_arrow sb_bottom_arrow sb_top_arrow spider star
+		  sb_right_arrow sb_down_arrow sb_up_arrow spider star
 		  target tcross xterm X_cursor)
     :depends use-custom-button-cursor-shape
     :group appearance
@@ -488,9 +488,9 @@
     "Cursor shape for shade button: \\left"
     :type (choice arrow box_spiral center_ptr circle cross cross_reverse
                   crosshair diamond_cross dotbox double_arrow draped_box
-		  fleur hand1 hand2 iron_cross left_ptr ll_angel mouse
+		  fleur hand1 hand2 iron_cross left_ptr ll_angle mouse
 		  pencil pirate plus question_arrow right_ptr sb_left_arrow
-		  sb_right_arrow sb_bottom_arrow sb_top_arrow spider star
+		  sb_right_arrow sb_down_arrow sb_up_arrow spider star
 		  target tcross xterm X_cursor)
     :depends use-custom-button-cursor-shape
     :group appearance
@@ -500,9 +500,9 @@
     "Cursor shape for sticky button: \\left"
     :type (choice arrow box_spiral center_ptr circle cross cross_reverse
                   crosshair diamond_cross dotbox double_arrow draped_box
-		  fleur hand1 hand2 iron_cross left_ptr ll_angel mouse
+		  fleur hand1 hand2 iron_cross left_ptr ll_angle mouse
 		  pencil pirate plus question_arrow right_ptr sb_left_arrow
-		  sb_right_arrow sb_bottom_arrow sb_top_arrow spider star
+		  sb_right_arrow sb_down_arrow sb_up_arrow spider star
 		  target tcross xterm X_cursor)
     :depends use-custom-button-cursor-shape
     :group appearance
@@ -512,9 +512,9 @@
     "Cursor shape for lock button: \\left"
     :type (choice arrow box_spiral center_ptr circle cross cross_reverse
                   crosshair diamond_cross dotbox double_arrow draped_box
-		  fleur hand1 hand2 iron_cross left_ptr ll_angel mouse
+		  fleur hand1 hand2 iron_cross left_ptr ll_angle mouse
 		  pencil pirate plus question_arrow right_ptr sb_left_arrow
-		  sb_right_arrow sb_bottom_arrow sb_top_arrow spider star
+		  sb_right_arrow sb_down_arrow sb_up_arrow spider star
 		  target tcross xterm X_cursor)
     :depends use-custom-button-cursor-shape
     :group appearance
@@ -524,9 +524,9 @@
     "Cursor shape for next-workspace button: \\left"
     :type (choice arrow box_spiral center_ptr circle cross cross_reverse
                   crosshair diamond_cross dotbox double_arrow draped_box
-		  fleur hand1 hand2 iron_cross left_ptr ll_angel mouse
+		  fleur hand1 hand2 iron_cross left_ptr ll_angle mouse
 		  pencil pirate plus question_arrow right_ptr sb_left_arrow
-		  sb_right_arrow sb_bottom_arrow sb_top_arrow spider star
+		  sb_right_arrow sb_down_arrow sb_up_arrow spider star
 		  target tcross xterm X_cursor)
     :depends use-custom-button-cursor-shape
     :group appearance
@@ -536,9 +536,9 @@
     "Cursor shape for previous-workspace button: \\left"
     :type (choice arrow box_spiral center_ptr circle cross cross_reverse
                   crosshair diamond_cross dotbox double_arrow draped_box
-		  fleur hand1 hand2 iron_cross left_ptr ll_angel mouse
+		  fleur hand1 hand2 iron_cross left_ptr ll_angle mouse
 		  pencil pirate plus question_arrow right_ptr sb_left_arrow
-		  sb_right_arrow sb_bottom_arrow sb_top_arrow spider star
+		  sb_right_arrow sb_down_arrow sb_up_arrow spider star
 		  target tcross xterm X_cursor)
     :depends use-custom-button-cursor-shape
     :group appearance
@@ -548,9 +548,9 @@
     "Cursor shape for rename button: \\left"
     :type (choice arrow box_spiral center_ptr circle cross cross_reverse
                   crosshair diamond_cross dotbox double_arrow draped_box
-		  fleur hand1 hand2 iron_cross left_ptr ll_angel mouse
+		  fleur hand1 hand2 iron_cross left_ptr ll_angle mouse
 		  pencil pirate plus question_arrow right_ptr sb_left_arrow
-		  sb_right_arrow sb_bottom_arrow sb_top_arrow spider star
+		  sb_right_arrow sb_down_arrow sb_up_arrow spider star
 		  target tcross xterm X_cursor)
     :depends use-custom-button-cursor-shape
     :group appearance
@@ -560,9 +560,9 @@
     "Cursor shape for move-resize button: \\left"
     :type (choice arrow box_spiral center_ptr circle cross cross_reverse
                   crosshair diamond_cross dotbox double_arrow draped_box
-		  fleur hand1 hand2 iron_cross left_ptr ll_angel mouse
+		  fleur hand1 hand2 iron_cross left_ptr ll_angle mouse
 		  pencil pirate plus question_arrow right_ptr sb_left_arrow
-		  sb_right_arrow sb_bottom_arrow sb_top_arrow spider star
+		  sb_right_arrow sb_down_arrow sb_up_arrow spider star
 		  target tcross xterm X_cursor)
     :depends use-custom-button-cursor-shape
     :group appearance
@@ -572,9 +572,9 @@
     "Cursor shape for raise-lower button: \\left"
     :type (choice arrow box_spiral center_ptr circle cross cross_reverse
                   crosshair diamond_cross dotbox double_arrow draped_box
-		  fleur hand1 hand2 iron_cross left_ptr ll_angel mouse
+		  fleur hand1 hand2 iron_cross left_ptr ll_angle mouse
 		  pencil pirate plus question_arrow right_ptr sb_left_arrow
-		  sb_right_arrow sb_bottom_arrow sb_top_arrow spider star
+		  sb_right_arrow sb_down_arrow sb_up_arrow spider star
 		  target tcross xterm X_cursor)
     :depends use-custom-button-cursor-shape
     :group appearance
@@ -616,6 +616,7 @@
   (defcustom custom-border-width 0
     "Width for the window border"
     :type number
+    :range (0 . 10)
     :group appearance
     :depends use-custom-border
     :after-set (lambda () (update-border-color-width)))

Attachment: signature.asc
Description: PGP signature