[pythonwifi] review of formatstrings and errno commits

[ Thread Index | Date Index | More lists.tuxfamily.org/pythonwifi Archives ]


Christoffer,

This is a code review of two recent commits.

"Changed formatstrings to be pep3101 compliant"[0]

I am glad to see this format of string interpolation used.  I prefer it to
the %% style.  While not relevant to these particular locations, the newer
style should also be easier to use if we want to start doing string
localization.

"Replaced error numbers with errno system symbols"[1]

Yes, this a better approach.


[0]
http://git.tuxfamily.org/pythonwifi/pythonwifi.git/commit/?h=kugg/api2011&id=91eed6d10857befc36b895accb25be7f47ad9673

[1]
http://git.tuxfamily.org/pythonwifi/pythonwifi.git/commit/?h=kugg/api2011&id=381d65a00566dfe62f9e94fd917736129d4fed2c

--
Sean







Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/