Re: [proaudio] [2976] media-sound/midipp: repoman is happy now.

[Karl Lindén <karl.j.linden@xxxxxxxxx>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On 11/11/15 22:52, subversion@xxxxxxxxxxxxx wrote:
> Revision: 2976 Author:   palo Date:     2015-11-11 22:52:17 +0100
> (Wed, 11 Nov 2015) Log Message: ----------- media-sound/midipp:
> repoman is happy now.
> 
> Also made some changes Karl mentioned.
> 
> Modified Paths: -------------- 
> trunk/overlays/proaudio/media-sound/midipp/Manifest 
> trunk/overlays/proaudio/media-sound/midipp/midipp-1.2.17.ebuild
> 
> Added Paths: ----------- 
> trunk/overlays/proaudio/media-sound/midipp/metadata.xml
> 
> Removed Paths: ------------- 
> trunk/overlays/proaudio/media-sound/midipp/midipp-1.2.17_rc1.ebuild
>
> 
Good, just a few things, which I include at appropriate places in the
below diff (I just extracted the necessary pieces).

- --- media-sound/midipp/metadata.xml	(nonexistent)
+++ media-sound/midipp/metadata.xml	(revision 2976)
@@ -0,0 +1,12 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!DOCTYPE pkgmetadata SYSTEM "http://www.gentoo.org/dtd/metadata.dtd";>
+<pkgmetadata>
+	<maintainer>
+		<email>proaudio@xxxxxxxxxxxxx</email>
+		<name>pro-audio overlay team</name>
+	</maintainer>
+	<use>
+		<flag name="jack">Enable JACK support</flag>
+		<flag name="qt5">use qt5 (if not set use qt4)</flag>
+	</use>
+</pkgmetadata>

You do not need to declare USE-flags here since both jack and qt5 are
global use flags. See /usr/portage/profiles/use.desc.

- --- media-sound/midipp/midipp-1.2.17.ebuild	(revision 2975)
+++ media-sound/midipp/midipp-1.2.17.ebuild	(revision 2976)
 src_configure(){
- -	cd midipp
- -	qmake HAVE_STATIC=YES HAVE_JACK=YES PREFIX=${D}
+	if use jack; then
+		JACK="HAVE_JACK=YES"
+	fi
+	if use qt5 ; then
+		eqmake5 HAVE_STATIC=YES $JACK PREFIX="${D}"
+	else
+		eqmake4 HAVE_STATIC=YES $JACK PREFIX="${D}"
+	fi
 }

There is a usex function in EAPI=5 [1], which you should use instead
of "if use jack ...", i.e. give qmake HAVE_JACK=$(usex jack YES NO),
and you'll be good.

I think you are unnecessarily duplicating code. You could create a
helper function called myqmake that wraps around the desired version
of qmake. Then you would only need to specify all your arguments to
qmake once, making the ebuild more readable. See the
media-sound/synthv1 ebuild(s).

Also here you still state PREFIX="${D}", which is wrong. It should be
PREFIX="${EPREFIX}"/usr unless the build system is terribly broken (in
which case you should do some research and write a patch to upstream
telling them this is wrong)

[1] https://devmanual.gentoo.org/ebuild-writing/eapi/index.html

Regards,
Karl
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.1

iQJ8BAEBCgBmBQJWRKhyXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQjJDQkQ0QjAzQ0JGMUVBQkJFQzM0QkQ3
NjRDMDk3OTVDODEyQjk3AAoJEHZMCXlcgSuXLHYP/jfksS83jeVPqy8l2O/xaaj7
xgd60jk/RTjQ804xonaNfl3JYrMdQsUGDyNZvdNsvENhNM7GE7WalCF50e8gJcs5
fNonPV1BATwSdi4SxWNlCudh4qAWUUpEAMeN1yVxf+rzy97SFChlwN0hTsXgXWNt
QA8Ie/uInIneQNJIjGQoUXtPorJ7fjVn7H2kx4IlA0jvNDd1RjYAeNiSsEepmlRz
hA2AjkJAftdSxG3S6rde0xp3oV73N+FQi6vcxlpWIDWGzn0CkN4wrhfRExM5EvY1
dqEoH96+uk3jZ+3lnY3iPQ8BURJgR+E0BzpYQ38U31Qt9wzfrObxft/OKFM8iLAQ
crwrJJkZC5w94Cxk0INm6ZgtfTMQVOqAW7rgrPetSxlmiQmLhNC6Pqq38dRhgZkq
QMvwdUurtq4HmWZsz0bD95B78YVIAgJEWE+mIpzLclV+C1Knl6ZgU9VZwn4f6IO8
8zJrwXR+AK9Va2AH+kfL6QjF4VSWUKeTwhjTr3mhIkgDa+NxXhU7sPAwT3Qq5n7N
OCzhRvlaTO0tFgCA50HFOmnqfSeg2eaKJF1HNmza3imdfAE0U/i+belkEc6sE1x3
UIAyFciWZjZmsGWht+6S5uDpUFGQZkcmAELW1OdSdWBBDBVHpuLAudRe76aKIyq6
DmTp0HEZ/lAIFpghh33Q
=HsX+
-----END PGP SIGNATURE-----