Re: [proaudio] [2976] media-sound/midipp: repoman is happy now.

[Ingolf Wagner <palipalo9@xxxxxxxxxxxxxx>]

Thank you for your advice.

 

- --- media-sound/midipp/midipp-1.2.17.ebuild   (revision 2975)
+++ media-sound/midipp/midipp-1.2.17.ebuild     (revision 2976)
 src_configure(){
- -     cd midipp
- -     qmake HAVE_STATIC=YES HAVE_JACK=YES PREFIX=${D}
+       if use jack; then
+               JACK="HAVE_JACK=YES"
+       fi
+       if use qt5 ; then
+               eqmake5 HAVE_STATIC=YES $JACK PREFIX="${D}"
+       else
+               eqmake4 HAVE_STATIC=YES $JACK PREFIX="${D}"
+       fi
 }

There is a usex function in EAPI=5 [1], which you should use instead
of "if use jack ...", i.e. give qmake HAVE_JACK=$(usex jack YES NO),
and you'll be good.

I don't know if that will work. In the scripts it looks like the they just check if the variable is set or not.

 

I think you are unnecessarily duplicating code. You could create a
helper function called myqmake that wraps around the desired version
of qmake. Then you would only need to specify all your arguments to
qmake once, making the ebuild more readable. See the
media-sound/synthv1 ebuild(s).

sounds good.

 

Also here you still state PREFIX="${D}", which is wrong. It should be
PREFIX="${EPREFIX}"/usr unless the build system is terribly broken (in
which case you should do some research and write a patch to upstream
telling them this is wrong)

[1] https://devmanual.gentoo.org/ebuild-writing/eapi/index.html

 

Yes I get sandbox problems if I don't set this parameter to ${D}, also tried to put the ${D} parameter in `src_install()` but did not help at all. I know this is wrong.

I'll create a patch in the next weeks. I might come back to you for questions.

Again may thanks for your advice! 

I'll push the changes in a minute.