Re: [proaudio] rivedell-1.5.1-r1-ebuild submission

[Dominique Michel <dominique.michel@xxxxxxxxx>]

Le Sun, 23 Aug 2009 15:07:58 -0500,
Emery Hemingway <emery@xxxxxxxxxxxxxxxxxx> a écrit :

> >> Is than any way to expedite getting this stuff in the tree?
> >Fill a bug report on gentoo bugzilla.
> Sorry if there was a misunderstanding, when I said I wanted stuff in the
> tree, I meant the overlay. I also apologize if I sound ungrateful for getting
> in at all. I myself don't think any thing this specialized should be in the
> main tree. 

On gentoo, when we said "in the tree", it is in the main portage tree.
Otherwise, we always said in the overlay. This is because an overlay can be
everywhere, not only into /usr/portage/loccal/... .

> 
> > When reviewing this ebuild, I see that, configure output a message about an
> > optional OggVorbis support. But the ebuild doesn't have an use flag for
> > that. Even the configure script from the tarball doesn't have an option for
> > that. That imply that, if the dependency are found, the ogg feature will be
> > compiled.
> >
> > From a gentoo dev perspective, it will have to patch (at least) the
> > configure script in order to add an ogg option, and to add an ogg use flag
> > > into the ebuild.
> I figured that without ogg support it would break some program features and 
> create inconsistancies with the documentation. Also the ogg and flac 
> libraries do the same thing, and I don't think flac is optional. But will see 
> if I build it without those two.

OK, if they are mandatory, it would be better to change the configure message
accordingly and to make configure to fail if those dependencies are not
found. Only you can know what is best.

> 
> > Another problem is than 2 potential use flags don't exist into the ebuild:
> >   --disable-hpi           disable AudioScience HPI sound support
> >   --disable-gpio          disable General Purpose Input/Output GPIO support
> I can't afford any of this hardware to test on, but I see what I can do for 
> the next release.

So, they are both for special hardwares. I think that it will be best to not
care about this into the ebuild, because to add those USE flags would force us
to make 2 other ebuilds, one for the hpi driver, the other for the gpio driver.

If no one have such a hardware, it is no way to test those 2 ebuilds. So, I
think that it is best to just forget about this, the current ebuild behaviour
will be fine.

> 
> Thanks for you time.
> 

You are welcome!
> 


-- 
If this message is send to an email list, please make sure to answer onto the
list, or you will be ignored.

"We have the heroes we deserve."