Re: [hatari-devel] Hatari screen dialog regression (size warnings) |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/hatari-devel Archives
]
- To: hatari-devel@xxxxxxxxxxxxxxxxxxx, Andreas Grabher <andreas_g86@xxxxxxxxxx>
- Subject: Re: [hatari-devel] Hatari screen dialog regression (size warnings)
- From: Eero Tamminen <oak@xxxxxxxxxxxxxx>
- Date: Wed, 13 Aug 2025 22:48:06 +0300
- Dkim-filter: OpenDKIM Filter v2.11.0 smtp.dnamail.fi 7FD442113E07
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=helsinkinet.fi; s=2025-03; t=1755114486; bh=atvUPlPwLVDIqldr5joaB5o3rumWhL5Y7Av87WMLJMk=; h=Date:Subject:To:References:From:In-Reply-To:From; b=NC9cIVmpZq3WayR+CQmgh5Moysw2A7a+YEuBf152+GRAOqPHgFbsAG/crMnKFgJuN xxSjFhlCoGKMXfCZERoXBnuTtSN2f+SP2YsApPTPozDnGs9dr4xoVMEzPOxEo8HsoM 3OAJPx/I1V2FVrzP8i2crm2g79h9XWsDgaCmwZuxXjDSJ9aKnUig1H4mBe7bXpH3hZ eOY6OOkwqcX8sdsL2djRiTj1kdDFwSol7Xw2YV4kH4vSb6RlmTRhpUu/aK5XsyVA5F 4S6nUZfIuNHYUabC6EtwCNsKcakGti/pwbPEh8CuOzDdqmuM3yI3HKKQBRB94FimD2 dhjYGOFWwB9yQ==
Hi,
On 13.8.2025 22.31, Andreas Grabher wrote:
Am 13.08.2025 um 21:25 schrieb Andreas Grabher <andreas_g86@xxxxxxxxxx>:
Am 13.08.2025 um 21:21 schrieb Eero Tamminen <oak@xxxxxxxxxxxxxx>:
Doesn't Previous have user configuration options that affect its window size?
It has not. If it had I would test my code with the smallest possible window size.
If you remember it... And Hatari has lot of options affecting screen
size, that one would need to remember.
This is not a runtime issue but a coding issue. If this is really needed it would be a bit less ugly to use assert() instead of comparing hard coded values at runtime on user’s machines. The result will always be the same.
I considered that, but the problem with asserts is that:
* Assers terminate the process, so one cannot view problematic dialog if
asserts are enabled
* Contributor may do builds with asserts disabled (that's CMake default
for release builds), and we want contributor to see the issue before
sending a patch
- Eero