[ Thread Index |
Date Index
| More lists.tuxfamily.org/hatari-devel Archives
]
- To: hatari-devel@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [hatari-devel] SDL3
- From: Thomas Huth <th.huth@xxxxxxxxx>
- Date: Fri, 7 Feb 2025 18:42:20 +0000
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1738953742; bh=JdkHBhL/mugl0QnFl9tprRv5of09SgpOSLzDyF760nc=; h=Date:From:To:Subject:Message-ID:MIME-Version:Content-Type: Content-Transfer-Encoding:From; b=iFsetNOxCFgJ3S7KAbK+KTCFx8O3qFiwrrnbFQXal68lDqrIRRH2D84DbtgkBwbJz Hlyr1ao2genYJCS1GSCTI/DwwA0JbpiQAU64MR4m6665ilfsGcY73kAAgByuucif9f UGvVLgPbUtwf04jgHiB3vs78B/Y2sNb9zh3SuAoc86U2m62cOCljEaoDnKzhPYWxaC llqWiWysyL1+jmrCUxo6M7V/Yb+kqoD+qv9X45YvBjLBWITYPF4rlmkSzbgwwmuuYK JdObzQTb/BkN6PHkcwv60DqDJfyNEGMoEy2LFtuQIgwHEK+wR6qJ4a6Hkw1jp9hMNY gysr1BwIRsLWw==
Am Sun, 2 Feb 2025 20:54:01 +0200
schrieb Eero Tamminen <oak@xxxxxxxxxxxxxx>:
> Hi,
>
> On 2.2.2025 11.01, Andreas Grabher wrote:
> >> Am 06.10.2024 um 10:53 schrieb Andreas Grabher <andreas_g86@xxxxxxxxxx>:
> > Now that SDL3 has been released I thought it is time to send another update to my patch. I think from here on there won’t be much changes. I have been running Previous with SDL3 only for quite some time now and it seems to work very well (better than SDL2). For not breaking things for those using systems with slow upgrades it would make sense to create a separate SDL3 branch.
>
> Thanks!
>
> IMHO having both SDL2 & SDL3 support in same branch, and just building
> Hatari for the SDL version available on the system, would be better.
>
> It seems that most of the changes could be handled with appropriate
> defines mapping the SDL2 function & define names to ones used by SDL3.
Yes, but they also changed e.g. the return code of functions, see e.g. this
part of the patch:
/* Init the SDL's audio subsystem: */
if (SDL_WasInit(SDL_INIT_AUDIO) == 0) {
- if (SDL_InitSubSystem(SDL_INIT_AUDIO) < 0) {
+ if (SDL_InitSubSystem(SDL_INIT_AUDIO) == false) {
Log_Printf(LOG_WARN, "[Audio] Could not init audio input: %s\n", SDL_GetError());
Statusbar_AddMessage("Error: Can't open SDL audio subsystem.", 5000);
return;
}
}
That's quite ugly, not sure how to handle that for both SDL versions at the
same time without lots of ugly #ifdefs ... :-(
Thomas