| Re: [hatari-devel] SCSI Driver improvements patch |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/hatari-devel Archives
]
- To: hatari-devel@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [hatari-devel] SCSI Driver improvements patch
- From: Uwe Seimet <Uwe.Seimet@xxxxxxxxx>
- Date: Mon, 3 Feb 2025 19:21:38 +0100
- Arc-authentication-results: i=1; strato.com; arc=none; dkim=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1738606905; s=strato-dkim-0002; d=strato.com; h=In-Reply-To:References:Message-ID:Subject:To:From:Date:Cc:Date:From: Subject:Sender; bh=Z6ks93fBMq+WcYzIq+NRe5I7+q5Fd+L8jZ6DQaqMiKw=; b=DTim9HHM9/BQ13QvmGGA8wVIZASYWJCU6nJMhOMSMZdRPchXSg6X6tMY/NpKhyakAx dzaEr/wbBC8BVY2tB5PWNDMB6pe63KlKdiOfMi/D1J3612gHH4Hbeu1kgIqymt4CAopT PKiwdLCCzHRw9jm5+QcDXu9jytMvxHGeAxIWnhkcQBfBzXB8/gJB+4wP+PlXV5j0sgSk VHmwXxdn5aThxNZEZsyEQ9syJbVuNkb6rTpDa/cTreAb6iS7ZsWOtSNBYoEv8F+L01Pr Mgxe8v8c0V+Ih7zf7VQYgDrpcc8+Emw64Ewj+Lm2weWvn8jLg9LWUF8LqNhIyaUaHszB aYjg==
- Arc-seal: i=1; a=rsa-sha256; t=1738606905; cv=none; d=strato.com; s=strato-dkim-0002; b=YCuijBBVRkQfYLMfM8+NuAU0YhwjdHR1c1Fw03MURSQTPZiAmeK4Xklkx72LLoT6rp wQZkSXurP7bnUiwSbEOqh+8gN6ayje5qvKlubn+5x5ah+V3N+PrHq9UEofxcPp/3lpXn FpNqDhNWD5HdUGtd23wrY+a4ZeSS3A7qMaWqOjnRzbt+fBk2f5Plgr6mmVhyCyqsIFRY dUUu4IbQN8gOSE3fbambJbjE5MYayUlKK6jjnH1UZeTLMdVQAYbCFlOcKN5R+fnEvNzA OfzuN4SNBy/dUSKq8/T1ugck2gfQ62rAgBy5tmz8RkVtaSGlLfjxu/eZD2PcUEEsxc2/ o15w==
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1738606905; s=strato-dkim-0002; d=seimet.de; h=In-Reply-To:References:Message-ID:Subject:To:From:Date:Cc:Date:From: Subject:Sender; bh=Z6ks93fBMq+WcYzIq+NRe5I7+q5Fd+L8jZ6DQaqMiKw=; b=g054/xKcmTQJWZM7Ks8rRVtrTv338j0V2BnzFjmQ9Aw2jssb1NYjbv4fFnUci0nofz 8VlRDFXpJRRCEK0KeYzsDizbcy8Sa7vKdyfURUdD7c53ZqJq0HBTO0wJuPkxHEUt1PCU B5z62LV0rIaveTTq/8CgFl2n3zjuayq7DW4XUh7bX7FhfuTzWgWg5iFvOBAKh2us02Ua zESF5Y//KEqu2tzeptiqSrJAAWXMSU9EaZ+hKgfURINsgU9yh1ZaIy/LIg0XJAum829U V5vF4gg5Mn40NvAVfZ2XIkGN//ib7KCa2bKCU45GluHe6/+fX1AhfuAHdPIeDOO0UITm I1MA==
- Dkim-signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; t=1738606905; s=strato-dkim-0003; d=seimet.de; h=In-Reply-To:References:Message-ID:Subject:To:From:Date:Cc:Date:From: Subject:Sender; bh=Z6ks93fBMq+WcYzIq+NRe5I7+q5Fd+L8jZ6DQaqMiKw=; b=ueFG4Waat6MChpNYtdWWGrTXPrdLE7QPt0dBT41IjscsiiUya0tMm76Wvc8t4lBVX7 Zd3MWCKERqGMwUDKwtCg==
Hi,
any chance to get feedback on my question? Maybe what I am asking for is not
possible or does not make sense. But my guess is that what I am supposed to
change in the SCSI Driver code will result in code sequences that also exist
elsewhere, or that other NatFeats code might also need.
When I say "optionally" I do not mean something you configure with cmake,
but something like a boolean parameter in the methods to be called.
Best regards
Uwe
> Hi,
>
> > * read_stack_pointer(): calls STMemory_STAddrToPointer(), but does not
> > check that the addresses are valid, as it should:
>
> Wouldn't it be better if Hatari was checking this in
> STMemory_STAddrToPointer(), at least optionally? The existing conversions
> between native and Atari address space already make the code in nf_scsidrv.c
> (and likely elsewhere) hard to read. I don't doubt that these checks are
> useful, but I wonder whether there are better solutions than explicit checks
> everywhere.
>
> Best regards
>
> Uwe
>
>