| Re: [hatari-devel] Minor CMake cleanup -> warnings with make 3.31 |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/hatari-devel Archives
]
- To: hatari-devel@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [hatari-devel] Minor CMake cleanup -> warnings with make 3.31
- From: Andreas Grabher <andreas_g86@xxxxxxxxxx>
- Date: Sat, 9 Nov 2024 18:28:05 +0100
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=icloud.com; s=1a1hai; t=1731173290; bh=q91QTO0dbU6TbrmchV0jlK7bllY8egygJk1XIyAqwc8=; h=Content-Type:From:Mime-Version:Subject:Date:Message-Id:To: x-icloud-hme; b=lHNUPiFZNHsU0eUfFJWKGmbvt6zqtI+1aqMrOf8ICPXARj//AD+9pQDyFwXDfVVpd 46WDxPghKVeoe/A/Qk3lH/x5Ei+kXYfvR5sJeSLRHivweCWnKOK360hIHPSo+Hoa/Y IkgpprlP7XPlpbQeuYdDXtTWR8TINuM9Y/cdceM/0cTKCl/Zdt71+MFcNl0c0cU6+p cGcP2amuzH5Xceyu8mnOUmyi0AbRXa8zgq02ejm5pE4/9+E7NbL3QQ2/t33z0xKF4d ayu7jKnOXGplG5QvZgr/Pj3s8Q2yolVmdRgTLbe8435GZwAYZ9mBOvKSiY8mVilHPn WgZY0CD7xEK3w==
> Am 09.11.2024 um 18:22 schrieb Thomas Huth <th.huth@xxxxxxxxx>:
>
> Am Sat, 9 Nov 2024 15:08:08 +0100
> schrieb Andreas Grabher <andreas_g86@xxxxxxxxxx>:
>
>>>> Am 09.11.2024 um 15:01 schrieb Nicolas Pomarède <npomarede@xxxxxxxxxxxx>:
>>>
>>>> Le 09/11/2024 à 14:58, Nicolas Pomarède a écrit :
>>>
>>>>> This is not yet a proper fix. But can you check if it removes all warnings? If not, please provide the full output with all warnings.
>>>>>
>>>> In the meantime I was also looking at a similar change and this removes the warning. I will commit this to main dev tree.
>>>>
>>>
>>> + forgot to tell : thanks for your patch :)
>>>
>> You’re welcome. I don’t know how to add the intended functionality in a proper way. But removing these lines won’t have any negative effects as those commands have been ignored ever since … until 3.31 without a warning: https://cmake.org/cmake/help/latest/policy/CMP0175.html
>
> Looking at the description on that page, I agree that removing the
> "DEPENDS" from cmake/DistClean.cmake is likely the right fix. But are you
> sure about src/CMakeLists.txt ? The occurance there was in a
> add_custom_target() statement, not in a add_custom_command() as it's
> mentioned in the description of CMP0175...?
>
> Thomas
>
Nicolas, can you test if you get a warning if you re-add the line in src/CMakeLists.txt?