Re: [hatari-devel] Minor CMake cleanup -> warnings with make 3.31

[Thomas Huth <th.huth@xxxxxxxxx>]

Am Sat, 9 Nov 2024 15:08:08 +0100
schrieb Andreas Grabher <andreas_g86@xxxxxxxxxx>:

> > Am 09.11.2024 um 15:01 schrieb Nicolas Pomarède <npomarede@xxxxxxxxxxxx>:
> > 
> > Le 09/11/2024 à 14:58, Nicolas Pomarède a écrit :
> >   
> >>> This is not yet a proper fix. But can you check if it removes all warnings? If not, please provide the full output with all warnings.
> >>>   
> >> In the meantime I was also looking at a similar change and this removes the warning. I will commit this to main dev tree.
> >>   
> > 
> > + forgot to tell : thanks for your patch :)
> >   
> You’re welcome. I don’t know how to add the intended functionality in a proper way. But removing these lines won’t have any negative effects as those commands have been ignored ever since … until 3.31 without a warning: https://cmake.org/cmake/help/latest/policy/CMP0175.html

Looking at the description on that page, I agree that removing the
"DEPENDS" from cmake/DistClean.cmake is likely the right fix. But are you
sure about src/CMakeLists.txt ? The occurance there was in a
add_custom_target() statement, not in a add_custom_command() as it's
mentioned in the description of CMP0175...?

 Thomas