Re: [hatari-devel] Wrong MODE SENSE data length for page code 0x3f

[ Thread Index | Date Index | More lists.tuxfamily.org/hatari-devel Archives ]


Hi,

On 26.10.2024 20.33, Uwe Seimet wrote:
Hi Eero and Andreas,

Just let me try to summarize what I would suggest to change in a first step:

1. If you want to retain SCSI-1 compatibility, which is not the standard most
    Atari software and hardware is using: For REQUEST SENSE nly return 4 bytes
    if the allocation length is *exactly* 0, i.e. do not say "<= 4" but "== 0".
2. In any other case return as much sense data as you have, but never more
    than the amount of bytes requested in the allocation length field.
3. For any other command there is no special rule for length 0.

If too many bytes are returned the initiator may crash because of a buffer
overflow, or other strange things may happen.

Thanks!   Could you also propose a patch?

Btw. Are there other differences between SCSI-1 & SCSI-2 that could be relevant for Hatari?

(I'm asking as started to wonder whether it would make sense to have some option to select which standard Hatari emulates...)


	- Eero




Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/