| Re: [hatari-devel] Wrong MODE SENSE data length for page code 0x3f |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/hatari-devel Archives
]
- To: hatari-devel@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [hatari-devel] Wrong MODE SENSE data length for page code 0x3f
- From: Uwe Seimet <Uwe.Seimet@xxxxxxxxx>
- Date: Sat, 26 Oct 2024 19:33:18 +0200
- Arc-authentication-results: i=1; strato.com; arc=none; dkim=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1729964012; s=strato-dkim-0002; d=strato.com; h=In-Reply-To:References:Message-ID:Subject:To:From:Date:Cc:Date:From: Subject:Sender; bh=eKc5+F+oUHVGBsvzq0bZMNVBP99NYjdDk10rrmvisUw=; b=eItmZyJ8SBFCyv+OOOM3AR+O7dI+ps0eXJcPeenQLggVLyKSqAnMFe+N+hgU/fcjee uF+lThJgU0XEUJuFackVBHtoxzpBdcHF4rf4kpqHEYa699/rnWt6J5MFvPY29Kfc4bu7 hOYeXC1rWEXJ9xGk54yzJT8Us+2u/B0+fFEk4e+ZkBsUA5iX/JRIQIBxxgRh5wUFibuP SQoi1g586vLEFcS7ft2z7gTg3hvLxoFtFxxlANFXYkVfT2ju2NynsEE7p/bysqWY9xsp 4rb1InFRjK0p8VUyKJZfVNbgiX65YOiiTpa7QdCVQ/Ul46S7gYB9SA9ElL2IytIR91Et NrKw==
- Arc-seal: i=1; a=rsa-sha256; t=1729964012; cv=none; d=strato.com; s=strato-dkim-0002; b=QdvxIJjGSOlDCOy2Bpe8L2x/IXG+1mLPRj5bt0mbnlIoEo+kA3FKIA64WjpYzGhRkc bfoXF+0QC3gc4blpWdB3WpcxLG/x9bj/Hkib7HZ0WbwpnLAIc23tdXLIy/NxAIUeMPbr WRwJdeXzA1KneJ+PWJocmRdw7z1gLeHhOM1f0Ecxw5bG6QxYpOGSGjOFhkX8IUpbEYYO 2p7ZY5aMqX/TKqdM1998MV+MZ8VFSkt+oqbhB6ZOu7nTOuEaRC+nuhRgInno4z8e0TVc htTyLI2FGDeGhcdn0A9Gm4kFChvoh8YvQsR1koEv0vOyEFs8fUmtfucaUshw2w33vVo3 +kYA==
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1729964012; s=strato-dkim-0002; d=seimet.de; h=In-Reply-To:References:Message-ID:Subject:To:From:Date:Cc:Date:From: Subject:Sender; bh=eKc5+F+oUHVGBsvzq0bZMNVBP99NYjdDk10rrmvisUw=; b=oBURQLBINI89+LYOP7n1Prke8JVnIJdAvS13FHmMhui88EUC3q1pW2DTiHvml89vtf VV9ltkBUD8tofCL84uyGbXI0lLNcJYxvCiRGtiBa340vL8353MaGj0DOMmlbsILpTyP5 MtpwwQCaQsxw0WLI43mKNQYJ1ApvLDDT4DsVXViK5TjJN6Q0kd8mHaLdgNHyqyirqU7Z VBIX6MzuK/L0pYQ+EAEUPw9QTMHCjJiLKS1GVJE1MqIbU/q45mVNEpMPpp9I5Kd8DcqX asjET16BU/mdzgiNP5sNgXwHvJz7cDYu85Mhl7k5HtTwyifNazVilkPl3JEJnin1r4N6 DAMw==
- Dkim-signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; t=1729964012; s=strato-dkim-0003; d=seimet.de; h=In-Reply-To:References:Message-ID:Subject:To:From:Date:Cc:Date:From: Subject:Sender; bh=eKc5+F+oUHVGBsvzq0bZMNVBP99NYjdDk10rrmvisUw=; b=1259AUpoVvMQ8dU7lSJ55QoUUltJ6Xm6KxQwlZrdXHuOe2WVotI+KJNJ4dQtm+tjIX 3GHgGbhiW3RX5vmspeCg==
Hi Eero and Andreas,
Just let me try to summarize what I would suggest to change in a first step:
1. If you want to retain SCSI-1 compatibility, which is not the standard most
Atari software and hardware is using: For REQUEST SENSE nly return 4 bytes
if the allocation length is *exactly* 0, i.e. do not say "<= 4" but "== 0".
2. In any other case return as much sense data as you have, but never more
than the amount of bytes requested in the allocation length field.
3. For any other command there is no special rule for length 0.
If too many bytes are returned the initiator may crash because of a buffer
overflow, or other strange things may happen.
Best regards
Uwe