Re: [hatari-devel] build fails on cirrus-ci for visualstudio target

[Thomas Huth <th.huth@xxxxxxxxx>]

On 21/10/2024 11.52, Nicolas Pomarède wrote:
> Hi
>
>
> build fails on cirrus-ci since "Do not print 'Checking:' for each TOS file 
> that we load" from 2024-10-13.
>
> https://cirrus-ci.com/build/4723926029303808
>
> but the change in this commit has nothing to do with the error message about 
> "strtok_r" not being found at link time :
>
>
> "C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci- 
> build\src\hatari.vcxproj" (default target) (11) ->
>         (Link target) ->
>           keymap.obj : error LNK2019: unresolved external symbol strtok_r 
> referenced in function Keymap_LoadRemapFile [C: 
> \Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci- 
> build\src\hatari.vcxproj]
>
> C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci- 
> build\src\Release\hatari.exe : fatal error LNK1120: 1 unresolved externals 
> [C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci- 
> build\src\hatari.vcxproj]
>
>
> the only thing I see is that MSVC went from 19.29.30154.0 to 19.29.30156.0 
> when configuring the build for "visualstudio"

That strtok_r has been introduced by:

https://git.tuxfamily.org/hatari/hatari.git/commit/?id=a22de5759741eaf8c6bf95ff7a0e128d516a11e5

.... so if it is not available with MSVC, I guess we have to switch back to 
the normal strtok() function?

 Thomas