Aw: [hatari-devel] build fails on cirrus-ci for visualstudio target

[Christian Zietz <czietz@xxxxxxx>]

Hi,

 

I think the attribution to the breaking commit is wrong. As far as I can see, Cirrus CI did not run on what (probably) is the real breaking commit:

https://github.com/hatari/hatari/commit/a22de5759741eaf8c6bf95ff7a0e128d516a11e5

 

Afaik, strtok_r is not available in Visual C's runtime library. However, strtok_s achieves a similar goal.

 

Regards

Christian

 

 

Gesendet: Montag, 21. Oktober 2024 um 11:52 Uhr
Von: "Nicolas Pomarède" <npomarede@xxxxxxxxxxxx>
An: hatari-devel@xxxxxxxxxxxxxxxxxxx
Betreff: [hatari-devel] build fails on cirrus-ci for visualstudio target

Hi


build fails on cirrus-ci since "Do not print 'Checking:' for each TOS
file that we load" from 2024-10-13.

https://cirrus-ci.com/build/4723926029303808

but the change in this commit has nothing to do with the error message
about "strtok_r" not being found at link time :


"C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\src\hatari.vcxproj"
(default target) (11) ->
(Link target) ->
keymap.obj : error LNK2019: unresolved external symbol
strtok_r referenced in function Keymap_LoadRemapFile
[C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\src\hatari.vcxproj]

C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\src\Release\hatari.exe
: fatal error LNK1120: 1 unresolved externals
[C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\src\hatari.vcxproj]


the only thing I see is that MSVC went from 19.29.30154.0 to
19.29.30156.0 when configuring the build for "visualstudio"

Any idea ?

Nicolas