Well, it's me and the other Hatari developers who finally have to maintain
this code in Hatari while you might be off to the next project, so please
understand that I did not do these changes to annoy you, but to get the
code into a shape where I can say "yes, this makes sense to me, that's
maintainable for me".
The problem is not that I think you are trying to annoy me. Actually I think it's the opposite. You were perhaps trying to not annoy me by not asking me, but the effect is unfortunately quite catastrophically the opposite of that intent, and for that I'm sorry.
What I'm asking is that please don't consider me to have abandoned an effort without asking me. I have spent a lot of time on this, and I intend to see it through.
I had not even submitted this yet, but in any submission I expect comments, requests for changes, I'm very accustomed to these processes in open source software. I want to help, I want to contribute, I'm spending my time trying to do this. If you ask me to restructure the submission for you, I will.
When you make a lot of changes to the work I've done without comment, I have to spend a lot more time reviewing it to understand what you changed and why.. I have to try to understand whether that change was an accident or deliberate. If I don't do this, it would be a waste of all the time I already spent researching and considering the problem to try and help. Do you understand this position?
I tried as hard as I could to investigate every change I was making. Every single case statement has a justification for me, and was not made without care, though there is always the possibility of error. I am happy to defer to your authority if ultimately you disagree about one or another but I still want a chance to explain what benefit I intended with it.
Now I'm even more confused ... Falcon TOS is a multi-language TOS, so I
cannot quite follow ... ?
Ah, well perhaps there is no reason to do that at all then. Thank you for the clarification. I don't have a lot of experience with Falcon, and I had assumed that not all TOS would be multi-language. As I said this seemed like a minor issue to begin with, and I did not even include it in my PR.