Re: [hatari-devel] Adding cache support for the MegaSTE -> DONE

[Nicolas Pomarède <npomarede@xxxxxxxxxxxx>]

Le 04/09/2024 à 01:46, Eero Tamminen a écrit :
> Hi Nicolas,
>
> On 4.9.2024 0.12, Nicolas Pomarède wrote:
> > Note that the cache needs to be flushed on every transfer when using 
> > Gemdos HD emulation, or normal FDC / HDC. Else this would transfer 
> > data to RAM without invalidating the cache (which has no means to know 
> > RAM has been modified), thus creating crashes in the emulated program 
> > sooner or later.
>
> This commit seems dubious:
> https://git.tuxfamily.org/hatari/hatari.git/commit/?id=4c803f1b952826af7b3409225e4000dee1eea62e
>
> * Why only "1" byte is flushed instead of "len" bytes (whole range)? [1]

laziness :) as the param 'len' is not used for now. But it should be 
fixed to the proper number of bytes being effectively copied.

> * Why flushing is added only to SafeCopy, and not to SafeClear?

It should too.


>      - Eero
>
> [1] The called flush functions in m68000.c don't do anything with the 
> passed addr + size args, but everything else tries to pass valid values 
> to them, so this should too.