| Re: [hatari-devel] Some minor changes for sdlgui.c |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/hatari-devel Archives
]
- To: Hatari devel list <hatari-devel@xxxxxxxxxxxxxxxxxxx>
- Subject: Re: [hatari-devel] Some minor changes for sdlgui.c
- From: Andreas Grabher <andreas_g86@xxxxxxxxxx>
- Date: Sat, 20 Jul 2024 18:11:08 +0200
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=icloud.com; s=1a1hai; t=1721491874; bh=Zk7X4kdGOUTEj5LzgmkKfpLDoMW6+6Nk9Tyma7XBsek=; h=From:Content-Type:Mime-Version:Subject:Date:To:Message-Id; b=UF2BmCVXK3TpAxVvzmhV/A2u2dYcAyewoat2xJPxR+jDAfWU1HqM+mIGhOzv7en6F 5X7A/bzFIRSZITDjxayAQaMOJN9CRVr/PwbrOos+l46Ng7qGeHyHXUuqD7xG7pKw3U Ovy+obAL/a5Y28lyye4tHraXIObHrwpTvZONad7nVzEipD2vsrer5C0RV3Y40idIiE Mh4nugIaKYRbdem606WbmBMOxJt1PBXQDFou0xxn629UnZtmfH/HWB1/FdYe90PIlX JedROn4g6lINHwtvLEXB6DXL3j2rk6YuSnX54aj0h6hq8lt4OdB7vRNKT68mVrDhCd BjEsE2hL5wKBg==
> Am 20.07.2024 um 15:45 schrieb Thomas Huth <th.huth@xxxxxxxxx>:
>
> Hi!
>
> Am Sat, 20 Jul 2024 08:15:18 +0200
> schrieb Andreas Grabher <andreas_g86@xxxxxxxxxx>:
>
>> I’d like to suggest this patch for Hatari that contains a few refinements:
>> Return object for checkbox and radiobutton. This makes it possible to easily determine which option was checked. I am using this for example for a mixed radiobutton and checkbox list in the GUI (see appended screenshot). If for example NeXTstation and Color are checked and one switches to NeXTcube I can uncheck the Color option. This can be done from switch(but) as for other buttons.
>
> Can't you simply use SG_EXIT for this case instead?
I can confirm that SG_EXIT works if I set it for all radiobuttons and checkboxes in that dialog. But is this really what SG_EXIT is intended for?
>
>> As I already suggested in another discussion we should not mix scancodes and symbolic keys. Even if they are likely to match for these keys it introduces an unnecessary source of bugs.
>> On some systems there seem to occur continuous SDL_KEYMAPCHANGED events. To prevent them from messing up GUI handling we should actively ignore them.
>
> Thanks, I pushed those two fixes to the repository now.
Great!
>
> Thomas
>
>
Andreas