| Re: [hatari-devel] Code execution on reset within the emulated Atari |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/hatari-devel Archives
]
- To: hatari-devel@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [hatari-devel] Code execution on reset within the emulated Atari
- From: Uwe Seimet <Uwe.Seimet@xxxxxxxxx>
- Date: Fri, 19 Jul 2024 11:54:01 +0200
- Arc-authentication-results: i=1; strato.com; arc=none; dkim=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1721382858; s=strato-dkim-0002; d=strato.com; h=In-Reply-To:References:Message-ID:Subject:To:From:Date:Cc:Date:From: Subject:Sender; bh=6nHDJns8EgQ2ig6ev/B3+E9h2FD35bl74vfE4VqB/jo=; b=dbrd9zDqnGVnreLKYRr4pueRFfNwssSxciAYlshgtexS0k7A6TXLnkk3LxWHuWQNjv iEzlr/Bo99E9QiOv4yHgg/hfeyjjj4b5JolsSKcZc9qY0WfGDbYEEf5WdJGgjTTowxVE 9udme77c/xqgyaK2QVlS9L0e7mTjkAodGpF+N7GjqMZREGm2v01jKGnPJ10gwxXFdVoJ 00xQaue4Jjv7a2tFqnC3kIbZlt91sKBvx/bPqWjcqrj2s3rXfKqG9QASIia5KNmMsbq7 TTENZMts7FNwYT0anGt8MikNAb3wRh6Ty3d36gaTWRokvR+IIVowyyZzz1TyrdmPIi/j delw==
- Arc-seal: i=1; a=rsa-sha256; t=1721382858; cv=none; d=strato.com; s=strato-dkim-0002; b=b0GjDKH5bcBUvolKisEoXGxRX9izoeeCn5FxfbAJSaXkNS5fa6HvbUNs+5jLwv0rT9 tJ2GreA/adf8fY8CgUbQbpAPSYIhnB89581oWlBjwp2HbJR+FC/mScxyvJOCLUKtMfg9 55Y6pR1RiWf9k9Y3eZ0o7X5OWnJi24/lg4yC8lm+xP0VKlUuqwvdzbVPUEXZNcHRFiCI 48/TyYeFY9vbuIkBWK545fUcIECfQKM0xcbvwy5ESc0Sh/SRVHIHG7/wLddBGOlCca26 iv5u5e2FyOzKB/+UTLF1gDF7Tu5tFkibUZ7Yg+eBeNS2h/0xC7MfziNTji0Pq6apxa+9 g7Cg==
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1721382858; s=strato-dkim-0002; d=seimet.de; h=In-Reply-To:References:Message-ID:Subject:To:From:Date:Cc:Date:From: Subject:Sender; bh=6nHDJns8EgQ2ig6ev/B3+E9h2FD35bl74vfE4VqB/jo=; b=bBBbmjeLek/nmludOUI/d0pJgTN0DT6RdKJqFqqhCI5rzDx/TIaG6DTNOEKkEbBPm3 ICcs/6JUVf3ts22ssyQ6+8rSnzVMLh/Dz/KEetrZrVSE0MLeBcW3zamGzd5iQKh4TOAk OyKORSMKJRCXfaXTWXzJ9d2yQpvg0FqULK0PKn8f1N1BbzzDKKzWImSBiZRNDJptu49m Y5eDd6uPIqJIhd5Iz8fRZsT3L8vF6FPRA7/TQw5DnmnuQ8U/ypMt/ziIyHvDT2W1ls/h QIpdAq6thmu+l3N6zwHp16IXrPq0Pze+z/IJMvKofHPOkRk9OKHo3l3IPfHxNpo8MPUv ikJA==
- Dkim-signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; t=1721382858; s=strato-dkim-0003; d=seimet.de; h=In-Reply-To:References:Message-ID:Subject:To:From:Date:Cc:Date:From: Subject:Sender; bh=6nHDJns8EgQ2ig6ev/B3+E9h2FD35bl74vfE4VqB/jo=; b=x5JlIT7EFj9OO8bd4Bq6i31WDHny2X8yHtctuG/75yv9POXVw+l17s5Otxm+seJTUT DRMdp1qkaIz0dYZVNJCA==
> On Freitag, 19. Juli 2024 11:18:24 CEST Uwe Seimet wrote:
> > As a result you run out of external handles.
>
> BTW, is that real a problem in practise? Yes, if Hatari does not reset the
> nf_scsi driver, those handles will be leaked. But how many handles are open
> when that happens? Typically, on linux you can have ~1024 file handles open.
nf_scsidrv reserves 32 handles, which usually is sufficient. Increasing
the number of handles would just be a work-around, but not a clean solution.
I will check whether customreset() can do the work. Currently
nf_scsidrv_reset is called in reset.c, but this only works if you reset the
emulation externally I assumeA
..
@Thomas In case customreset() works, the call in reset.c can probably be
removed?